linux-kernel - Re: [PATCH] crypto: ux500/hash: Add empty export and import

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <3a52171a-0054-fcbf-ad45-062c72e5877e@partner.samsung.com>
Date:   Thu, 18 Jan 2018 13:52:50 +0100
From:   Kamil Konieczny <k.konieczny@...tner.samsung.com>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        linux-crypto@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Joakim Bech <joakim.bech@...aro.org>
Subject: Re: [PATCH] crypto: ux500/hash: Add empty export and import



On 18.01.2018 11:06, Linus Walleij wrote:
> On Tue, Jan 16, 2018 at 5:32 PM, Kamil Konieczny
> <k.konieczny@...tner.samsung.com> wrote:
> 
>> Crypto framework will require async hash export/import, so add empty
>> functions to prevent OOPS.
>>
>> Signed-off-by: Kamil Konieczny <k.konieczny@...tner.samsung.com>
> 
> Acked-by: Linus Walleij <linus.walleij@...aro.org>
> 
> But why isn't the framework code just checking the vtable for NULL?
> 
> if (foo->fp)
>     foo->fp(bar);

This will be inefficient, 
it should be checked once at ahash alg register,
or with the old method by using wrapper

-- 
Best regards,
Kamil Konieczny
Samsung R&D Institute Poland