linux-kernel - Re: [Patch v6 02/12] [media] s5p-mfc: Adding initial support for MFC v10.10

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1516278981.22129.12.camel@smitha-fedora>
Date:   Thu, 18 Jan 2018 18:06:21 +0530
From:   Smitha T Murthy <smitha.t@...sung.com>
To:     Philippe Ombredanne <pombredanne@...b.com>
Cc:     "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>,
        Linux Media Mailing List <linux-media@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>, kyungmin.park@...sung.com,
        kamil@...as.org, jtp.park@...sung.com, a.hajda@...sung.com,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        pankaj.dubey@...sung.com, krzk@...nel.org,
        m.szyprowski@...sung.com, s.nawrocki@...sung.com,
        Rob Herring <robh+dt@...nel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>
Subject: Re: [Patch v6 02/12] [media] s5p-mfc: Adding initial support for
 MFC v10.10

On Fri, 2017-12-08 at 14:25 +0100, Philippe Ombredanne wrote:
> Smitha,
> 
> On Fri, Dec 8, 2017 at 10:08 AM, Smitha T Murthy <smitha.t@...sung.com> wrote:
> > Adding the support for MFC v10.10, with new register file and
> > necessary hw control, decoder, encoder and structural changes.
> >
> > CC: Rob Herring <robh+dt@...nel.org>
> > CC: devicetree@...r.kernel.org
> > Signed-off-by: Smitha T Murthy <smitha.t@...sung.com>
> > Reviewed-by: Andrzej Hajda <a.hajda@...sung.com>
> > Acked-by: Rob Herring <robh@...nel.org>
> []
> > --- /dev/null
> > +++ b/drivers/media/platform/s5p-mfc/regs-mfc-v10.h
> > @@ -0,0 +1,36 @@
> > +/*
> > + * Register definition file for Samsung MFC V10.x Interface (FIMV) driver
> > + *
> > + * Copyright (c) 2017 Samsung Electronics Co., Ltd.
> > + *     http://www.samsung.com/
> > + *
> > + * This program is free software; you can redistribute it and/or modify
> > + * it under the terms of the GNU General Public License version 2 as
> > + * published by the Free Software Foundation.
> > + */
> 
> Have you considered using the new SPDX ids instead of this fine legalese? e.g.:
> 
> // SPDX-License-Identifier: GPL-2.0
> 
> This is much shorter and neater (unless you are a legalese lover of
> course!)  Check also Thomas doc patches and Linus comments on why he
> prefers the C++ comment style for these.
> 
> And even better could be this more compact form? I am a big fan of the
> C++ style comments for these (and so is Linus)
> 
> // SPDX-License-Identifier: GPL-2.0
> // Copyright (c) 2017 Samsung Electronics Co., Ltd.
> // Register definition file for Samsung MFC V10.x Interface (FIMV) driver
> 
> You can also read this fine article from a fellow Samsung colleague
> [1]. And if you ever consider doing this for all Samsung's past,
> present and future contributions, you will have my deep gratitude
> 
> [1] https://blogs.s-osg.org/linux-kernel-license-practices-revisited-spdx/
> 
Ok I will change to the SPDX license in the next patch series for the
v10 register file. Correspondingly for the MFC driver's files I will
update the license as a separate patch and submit.