linux-kernel - Re: [PATCH 2/6] backlight/generic-bl: remove DRIVER1 state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACvgo52kp7QFcV77V29NW_T1X4yZEY2f5iE-geYfpvfnswS=xw@mail.gmail.com>
Date:   Thu, 18 Jan 2018 13:08:01 +0000
From:   Emil Velikov <emil.l.velikov@...il.com>
To:     Daniel Thompson <daniel.thompson@...aro.org>
Cc:     Daniel Vetter <daniel.vetter@...ll.ch>,
        DRI Development <dri-devel@...ts.freedesktop.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Jingoo Han <jingoohan1@...il.com>,
        Daniel Vetter <daniel.vetter@...el.com>,
        Lee Jones <lee.jones@...aro.org>
Subject: Re: [PATCH 2/6] backlight/generic-bl: remove DRIVER1 state

On 17 January 2018 at 16:37, Daniel Thompson <daniel.thompson@...aro.org> wrote:
>
>
> On 17/01/18 14:36, Emil Velikov wrote:
>>
>> On 17 January 2018 at 14:01, Daniel Vetter <daniel.vetter@...ll.ch> wrote:
>>>
>>> Nothing in the entire tree ever sets this, which means this is dead
>>> code. Remove it.
>>>
>>> Cc: Lee Jones <lee.jones@...aro.org>
>>> Cc: Daniel Thompson <daniel.thompson@...aro.org>
>>> Cc: Jingoo Han <jingoohan1@...il.com>
>>> Signed-off-by: Daniel Vetter <daniel.vetter@...el.com>
>>> ---
>>>   drivers/video/backlight/generic_bl.c | 5 -----
>>
>>
>> Fly-by comment, while waiting for coffee to kick-in.
>> I think this patch should be after pandora/others have stopped abusing
>> BL_CORE_DRIVER1.
>
>
> You sure?
>
> I can't see why the use or disuse of BL_CORE_DRIVER1 in this driver should
> influence another independent driver.
>
Right my bad. Got mislead by the driver name.

-Emil