linux-kernel - Re: [PATCH] kconfig: Document SYMBOL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7LNATyu22dUa1Y2Yif4e7wyngTZ8D0HGtHH6wzx59f2OL5NA@mail.gmail.com>
Date:   Thu, 18 Jan 2018 22:50:11 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Ulf Magnusson <ulfalizer@...il.com>
Cc:     Linux Kbuild mailing list <linux-kbuild@...r.kernel.org>,
        Sam Ravnborg <sam@...nborg.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kconfig: Document SYMBOL_OPTIONAL logic

2018-01-14 18:56 GMT+09:00 Ulf Magnusson <ulfalizer@...il.com>:
> Not obvious, especially if you don't already know how choices are
> implemented.
>
> No functional changes. Only comments added.
>
> Signed-off-by: Ulf Magnusson <ulfalizer@...il.com>
> ---
>  scripts/kconfig/menu.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c
> index 92d3f06cd8a2..372eb5d9fef3 100644
> --- a/scripts/kconfig/menu.c
> +++ b/scripts/kconfig/menu.c
> @@ -548,6 +548,15 @@ void menu_finalize(struct menu *parent)
>                 sym->flags |= SYMBOL_WARNED;
>         }
>
> +       /*
> +        * For non-optional choices, add a reverse dependency (corresponding to
> +        * a select) of '<visibility> && m'. This prevents the user from
> +        * setting the choice mode to 'n' when the choice is visible.
> +        *
> +        * This would also work for non-choice symbols, but only non-optional
> +        * choices clear SYMBOL_OPTIONAL as of writing. Choices are implemented
> +        * as a type of symbol.
> +        */
>         if (sym && !sym_is_optional(sym) && parent->prompt) {
>                 sym->rev_dep.expr = expr_alloc_or(sym->rev_dep.expr,
>                                 expr_alloc_and(parent->prompt->visible.expr,
> --


Applied to linux-kbuild/kconfig.  Thanks!



-- 
Best Regards
Masahiro Yamada