linux-kernel - Re: [PATCH -next] of: platform: fix OF node refcount leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 18 Jan 2018 08:57:15 -0600
From:   Rob Herring <robh+dt@...nel.org>
To:     Sudeep Holla <sudeep.holla@....com>
Cc:     "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Loys Ollivier <lollivier@...libre.com>,
        Andy Gross <andy.gross@...aro.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Frank Rowand <frowand.list@...il.com>
Subject: Re: [PATCH -next] of: platform: fix OF node refcount leak

On Thu, Jan 18, 2018 at 4:43 AM, Sudeep Holla <sudeep.holla@....com> wrote:
> We need to call of_node_put() for device nodes obtained with
> of_find_node_by_path().
>
> Fixes: 3aa0582fdb82 ("of: platform: populate /firmware/ node from of_platform_default_populate_init()")
> Reported-by: Loys Ollivier <lollivier@...libre.com>
> Cc: Rob Herring <robh+dt@...nel.org>
> Cc: Frank Rowand <frowand.list@...il.com>
> Signed-off-by: Sudeep Holla <sudeep.holla@....com>
> ---
>  drivers/of/platform.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> Hi Rob,
>
> You had Acked the original patch and it's queued via ARM SoC. So can you
> please provide ack on this if you are OK with the change.

Acked-by: Rob Herring <robh@...nel.org>