linux-kernel - Re: [PATCH v3 1/2] nvme: add tracepoint for nvme_setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180118152134.GB24168@lst.de>
Date:   Thu, 18 Jan 2018 16:21:34 +0100
From:   Christoph Hellwig <hch@....de>
To:     Johannes Thumshirn <jthumshirn@...e.de>
Cc:     Christoph Hellwig <hch@....de>, Sagi Grimberg <sagi@...mberg.me>,
        Keith Busch <keith.busch@...el.com>,
        Linux Kernel Mailinglist <linux-kernel@...r.kernel.org>,
        Hannes Reinecke <hare@...e.de>,
        Linux NVMe Mailinglist <linux-nvme@...ts.infradead.org>
Subject: Re: [PATCH v3 1/2] nvme: add tracepoint for nvme_setup_cmd

On Wed, Jan 17, 2018 at 11:53:35AM +0100, Johannes Thumshirn wrote:
> +nvme-core-y				:= trace.o core.o

trace.o should be conditional on CONFIG_TRACEPOINTS.

> +TRACE_EVENT(nvme_setup_cmd,
> +	    TP_PROTO(struct nvme_command *cmd),
> +	    TP_ARGS(cmd),
> +	    TP_STRUCT__entry(
> +		    __field(__u8, opcode)
> +		    __field(__u8, flags)
> +		    __field(__u16, cid)
> +		    __field(__le32, nsid)
> +		    __field(__le64, metadata)
> +		    __field_struct( struct nvme_command, cmnd )

This still copies the whole SQE.  I think that is way to much to
copy, especially given that you also copy many of the fields separately
as well.