linux-kernel - Re: [PATCH -next] mtd: ubi: wl: Fix error return code in ubi_wl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1565095.G3YoHPv5dZ@blindfold>
Date:   Thu, 18 Jan 2018 16:46:17 +0100
From:   Richard Weinberger <richard@....at>
To:     Boris Brezillon <boris.brezillon@...e-electrons.com>
Cc:     Wei Yongjun <weiyongjun1@...wei.com>,
        Artem Bityutskiy <dedekind1@...il.com>,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        Marek Vasut <marek.vasut@...il.com>,
        linux-mtd@...ts.infradead.org,
        Cyrille Pitchen <cyrille.pitchen@...ev4u.fr>,
        Brian Norris <computersforpeace@...il.com>,
        David Woodhouse <dwmw2@...radead.org>
Subject: Re: [PATCH -next] mtd: ubi: wl: Fix error return code in ubi_wl_init()

Boris, Wei Yongjun,

Am Donnerstag, 18. Januar 2018, 16:34:45 CET schrieb Boris Brezillon:
> On Thu, 18 Jan 2018 15:11:32 +0100
> 
> Boris Brezillon <boris.brezillon@...e-electrons.com> wrote:
> > On Thu, 18 Jan 2018 15:08:01 +0100
> > 
> > Boris Brezillon <boris.brezillon@...e-electrons.com> wrote:
> > > On Thu, 18 Jan 2018 14:05:05 +0000
> > > 
> > > Wei Yongjun <weiyongjun1@...wei.com> wrote:
> > > > Fix to return error code -ENOMEM from the kmem_cache_alloc() error
> > > > handling case instead of 0, as done elsewhere in this function.
> > > 
> > > I guess you've used a static analysis code to detect this problem, can
> > > you name it in the commit message, and paste the error/warning message
> > > it reported next time you submit this kind of patch.
> > > 
> > > > Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
> > > 
> > > NAck. I you read the code you'll see that err is initialized to -ENOMEM
> > > here [1], so these changes are actually not needed.
> > 
> > Sorry, just realized I was wrong. It seems that err can be overridden by
> > [2]. So this patch is indeed fixing a real problem.
> > 
> > Reviewed-by: Boris Brezillon <boris.brezillon@...e-electrons.com>
> 
> Oh, and you can add:
> 
> Fixes: f78e5623f45b ("ubi: fastmap: Erase outdated anchor PEBs during
> attach")

Good catch!

Thanks,
//richard