linux-kernel - [PATCH 2/5] irqchip/irq-gic-v2m: Improve a size determination in gicv2m_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 18 Jan 2018 17:24:30 +0100
From:   SF Markus Elfring <elfring@...rs.sourceforge.net>
To:     kernel-janitors@...r.kernel.org,
        Jason Cooper <jason@...edaemon.net>,
        Marc Zyngier <marc.zyngier@....com>,
        Thomas Gleixner <tglx@...utronix.de>
Cc:     LKML <linux-kernel@...r.kernel.org>
Subject: [PATCH 2/5] irqchip/irq-gic-v2m: Improve a size determination in
 gicv2m_init_one()

From: Markus Elfring <elfring@...rs.sourceforge.net>
Date: Thu, 18 Jan 2018 16:07:41 +0100

Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
---
 drivers/irqchip/irq-gic-v2m.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/irqchip/irq-gic-v2m.c b/drivers/irqchip/irq-gic-v2m.c
index b795fefafb12..930261710ba2 100644
--- a/drivers/irqchip/irq-gic-v2m.c
+++ b/drivers/irqchip/irq-gic-v2m.c
@@ -306,9 +306,8 @@ static int __init gicv2m_init_one(struct fwnode_handle *fwnode,
 				  struct resource *res)
 {
 	int ret;
-	struct v2m_data *v2m;
+	struct v2m_data *v2m = kzalloc(sizeof(*v2m), GFP_KERNEL);
 
-	v2m = kzalloc(sizeof(struct v2m_data), GFP_KERNEL);
 	if (!v2m)
 		return -ENOMEM;
 
-- 
2.15.1