linux-kernel - Re: [PATCH] input: cyapa: remove redundant assignment to 'pwr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180118192225.n6scc424psan7iwn@dtor-ws>
Date:   Thu, 18 Jan 2018 11:22:25 -0800
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Colin King <colin.king@...onical.com>
Cc:     Guenter Roeck <linux@...ck-us.net>, linux-input@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] input: cyapa: remove redundant assignment to 'pwr_cmd'

On Wed, Jan 17, 2018 at 10:45:19AM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The variable pwr_cmd is being assigned to cyapa->suspend_power_mode
> twice, once during the declaration and once after taking an
> interruptible mutex lock.  Remove the redundant first assignment
> since the value is never read and it is outside the mutex lock.
> 
> Cleans up clang warning:
> drivers/input/mouse/cyapa.c:743:5: warning: Value stored to 'pwr_cmd'
> during its initialization is never read
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Applied, thank you.

> ---
>  drivers/input/mouse/cyapa.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/input/mouse/cyapa.c b/drivers/input/mouse/cyapa.c
> index fd8865c65caf..dfd3873513e4 100644
> --- a/drivers/input/mouse/cyapa.c
> +++ b/drivers/input/mouse/cyapa.c
> @@ -740,7 +740,7 @@ static ssize_t cyapa_show_suspend_scanrate(struct device *dev,
>  					   char *buf)
>  {
>  	struct cyapa *cyapa = dev_get_drvdata(dev);
> -	u8 pwr_cmd = cyapa->suspend_power_mode;
> +	u8 pwr_cmd;
>  	u16 sleep_time;
>  	int len;
>  	int error;
> -- 
> 2.15.1
> 

-- 
Dmitry