linux-kernel - Re: [PATCH v3] USB: serial: option: add id for Motorola Solutions TETRA PEI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180118032607.GF3286@localhost>
Date:   Thu, 18 Jan 2018 14:26:07 +1100
From:   Johan Hovold <johan@...nel.org>
To:     Max Schulze <max.schulze@...teo.de>
Cc:     Johan Hovold <johan@...nel.org>, gregkh@...uxfoundation.org,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] USB: serial: option: add id for Motorola Solutions
 TETRA PEI

On Tue, Jan 16, 2018 at 12:12:33AM +0100, Max Schulze wrote:
> 
> > This indicates that option isn't the right driver for this for device.
> >
> > I think we should add a new simple driver for it instead, which reports
> > that modem control isn't (yet) supported (yes, your python script would
> > need to be updated). This can be extended into a "real" driver, should
> > we learn more about the protocol used.
> 
> Thank you. Tested with miniterm.py - it doesn't need any changes because
> no erroneous URB's are sent.

That's good. In your initial mail you mentioned that it was doing a
TIOCMBIS that was failing with the generic driver (which is essentially
the same thing as a "simple" driver).

> [  172.249297] usb_serial_simple 1-1.4:1.0: motorola_tetra converter
> detected
> [  172.249403] usb 1-1.4: motorola_tetra converter now attached to ttyUSB0
> [  172.249502] usb_serial_simple 1-1.4:1.1: motorola_tetra converter
> detected
> [  172.249578] usb 1-1.4: motorola_tetra converter now attached to ttyUSB1
> 
> > >From a7ab87acf85b67303e7bf606734176a365aae9cd Mon Sep 17 00:00:00 2001
> > From: Johan Hovold <johan@...nel.org>
> > Date: Fri, 12 Jan 2018 17:53:35 +0100
> > Subject: [PATCH] USB: serial: simple: add Motorola Tetra driver
> >
> > Add new Motorola Tetra (simple) driver for Motorola Solutions TETRA PEI
> > devices.
> >
> > D:  Ver= 2.00 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs=  1
> > P:  Vendor=0cad ProdID=9011 Rev=24.16
> > S:  Manufacturer=Motorola Solutions Inc.
> > S:  Product=Motorola Solutions TETRA PEI interface
> > C:  #Ifs= 2 Cfg#= 1 Atr=80 MxPwr=500mA
> > I:  If#= 0 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=(none)
> > I:  If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=00 Prot=00 Driver=(none)
> >
> > Note that these devices do not support the CDC SET_CONTROL_LINE_STATE
> > request (for any interface).
> >
> > Reported-by: Max Schulze <max.schulze@...teo.de>
> > Cc: stable <stable@...r.kernel.org>
> > Signed-off-by: Johan Hovold <johan@...nel.org>

> Works as-is. Tested in miniterm.py and minicom.
> 
> Tested-by: Max Schulze <max.schulze@...teo.de>

Thanks for testing!

Johan