linux-kernel - Re: [PATCH v3 1/2] media: dt-bindings: Add OF properties to ov7670

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180118222354.wk74rl4x4ay4gnzc@valkosipuli.retiisi.org.uk>
Date:   Fri, 19 Jan 2018 00:23:54 +0200
From:   Sakari Ailus <sakari.ailus@....fi>
To:     Jacopo Mondi <jacopo+renesas@...ndi.org>
Cc:     corbet@....net, mchehab@...nel.org, robh+dt@...nel.org,
        mark.rutland@....com, linux-media@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] media: dt-bindings: Add OF properties to ov7670

On Fri, Jan 12, 2018 at 06:56:47PM +0100, Jacopo Mondi wrote:
> Describe newly introduced OF properties for ov7670 image sensor.
> The driver supports two standard properties to configure synchronism
> signals polarities and one custom property already supported as
> platform data options by the driver to suppress pixel clock during
> horizontal blanking.
> 
> Re-phrase child nodes description while at there.
> 
> Signed-off-by: Jacopo Mondi <jacopo+renesas@...ndi.org>
> ---
>  Documentation/devicetree/bindings/media/i2c/ov7670.txt | 18 ++++++++++++++++--
>  1 file changed, 16 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/ov7670.txt b/Documentation/devicetree/bindings/media/i2c/ov7670.txt
> index 826b656..7c89ea5 100644
> --- a/Documentation/devicetree/bindings/media/i2c/ov7670.txt
> +++ b/Documentation/devicetree/bindings/media/i2c/ov7670.txt
> @@ -9,14 +9,23 @@ Required Properties:
>  - clocks: reference to the xclk input clock.
>  - clock-names: should be "xclk".
>  
> +Required Endpoint Properties:
> +- hsync-active: active state of the HSYNC signal, 0/1 for LOW/HIGH respectively.
> +  Default is active high.
> +- vsync-active: active state of the VSYNC signal, 0/1 for LOW/HIGH respectively.
> +  Default is active high.

If the properties are required, you'll have no default value for them.

Other than that, looks good to me.

> +
>  Optional Properties:
>  - reset-gpios: reference to the GPIO connected to the resetb pin, if any.
>    Active is low.
>  - powerdown-gpios: reference to the GPIO connected to the pwdn pin, if any.
>    Active is high.
> +- ov7670,pclk-hb-disable: a boolean property to suppress pixel clock output
> +  signal during horizontal blankings.
>  
> -The device node must contain one 'port' child node for its digital output
> -video port, in accordance with the video interface bindings defined in
> +The device node must contain one 'port' child node with one 'endpoint' child
> +sub-node for its digital output video port, in accordance with the video
> +interface bindings defined in:
>  Documentation/devicetree/bindings/media/video-interfaces.txt.
>  
>  Example:
> @@ -34,8 +43,13 @@ Example:
>  			assigned-clocks = <&pck0>;
>  			assigned-clock-rates = <25000000>;
>  
> +			ov7670,pclk-hb-disable;
> +
>  			port {
>  				ov7670_0: endpoint {
> +					hsync-active = <0>;
> +					vsync-active = <0>;
> +
>  					remote-endpoint = <&isi_0>;
>  				};
>  			};
> -- 
> 2.7.4
> 

-- 
Sakari Ailus
e-mail: sakari.ailus@....fi