linux-kernel - Re: linux-next: build warning after merge of the crypto tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2a629f26-de6b-803e-a07b-4cfec3b59d13@chelsio.com>
Date:   Fri, 19 Jan 2018 09:51:43 +0530
From:   Harsh Jain <harsh@...lsio.com>
To:     Stephen Rothwell <sfr@...b.auug.org.au>,
        Herbert Xu <herbert@...dor.apana.org.au>
Cc:     Linux-Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: linux-next: build warning after merge of the crypto tree

Hi Herbert,

It's an indentation issue. Seems checkpatch and default compile options does not report this warning.

How would you like to take the fix. Should I sent whole series again with fix or only indentation patch.


On 19-01-2018 07:19, Stephen Rothwell wrote:
> Hi Herbert,
>
> After merging the crypto tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
>
> drivers/crypto/chelsio/chcr_algo.c: In function 'create_authenc_wr':
> drivers/crypto/chelsio/chcr_algo.c:2113:2: warning: this 'if' clause does not guard... [-Wmisleading-indentation]
>   if (error)
>   ^~
> drivers/crypto/chelsio/chcr_algo.c:2115:3: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'if'
>    dnents = sg_nents_xlen(req->dst, assoclen, CHCR_DST_SG_SIZE, 0);
>    ^~~~~~
>
> Introduced by commit
>
>   e1a018e607a3 ("crypto: chelsio - Remove dst sg size zero check")
>