linux-kernel - Re: [PATCH] selftests/x86: Add <test_name>{,_32,

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 18 Jan 2018 17:28:34 -0700
From:   Shuah Khan <shuah@...nel.org>
To:     Andy Lutomirski <luto@...nel.org>, Dmitry Safonov <dima@...sta.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Ingo Molnar <mingo@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@...r.kernel.org>, X86 ML <x86@...nel.org>,
        Shuah Khan <shuahkh@....samsung.com>,
        Shuah Khan <shuah@...nel.org>
Subject: Re: [PATCH] selftests/x86: Add <test_name>{,_32,_64} targets

On 01/18/2018 04:10 PM, Andy Lutomirski wrote:
> On Thu, Jan 18, 2018 at 2:19 PM, Dmitry Safonov <dima@...sta.com> wrote:
>> One can only use `make all` or `make <test_name>_<bitness>`
>> as make targets.
>> `make <test_name>` doesn't work as Ingo noticed:
>>   x86> make test_vsyscall
>>   gcc -O2 -g -std=gnu99 -pthread -Wall -no-pie test_vsyscall.c -o test_vsyscall
>>   /tmp/aBaoo3nb.o: In function `init_vdso':
>>   test_vsyscall.c:68: undefined reference to `dlopen'
>>   test_vsyscall.c:76: undefined reference to `dlsym'
>>   test_vsyscall.c:80: undefined reference to `dlsym'
>>   test_vsyscall.c:84: undefined reference to `dlsym'
>>   test_vsyscall.c:88: undefined reference to `dlsym'
>>   test_vsyscall.c:70: undefined reference to `dlopen'
>>   collect2: error: ld returned 1 exit status
>>   <builtin>: recipe for target 'test_vsyscall' failed
>>   make: *** [test_vsyscall] Error 1
>>
>> Makefile target substitution neither works :-/
>>
>> Generate .PHONY targets per-test and fix target substitution.
> 
> Reviewed-by: Andy Lutomirski <luto@...nel.org>
> 
> 

Thanks for taking care of this. I plan to get this into 4.16-rc1
unless there is a dependency on x86 tree.

thanks,
-- Shuah