linux-kernel - Re: [PATCH-next] init/main.c: make local symbol static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180118193134.59135fde@gandalf.local.home>
Date:   Thu, 18 Jan 2018 19:31:34 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Christopher Díaz Riveros <chrisadr@...too.org>
Cc:     Tom Lendacky <thomas.lendacky@....com>,
        Randy Dunlap <rdunlap@...radead.org>, mingo@...nel.org,
        akpm@...ux-foundation.org, tglx@...utronix.de,
        keescook@...omium.org, lauraa@...eaurora.org, mhocko@...e.com,
        tal.shorer@...il.com, viresh.kumar@...aro.org, lokeshvutla@...com,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH-next] init/main.c: make local symbol static

On Thu, 18 Jan 2018 18:33:27 -0500
Christopher Díaz Riveros <chrisadr@...too.org> wrote:

> > > What about the other user(s) of envp_init?  
> > 
> > It looks like it's referenced in init/do_mounts_initrd.c.  Rather
> > than making it static, it should be declared in .h file.
> >   
> 
> Ok, I'll try to figure it out, akpm accepted the patch in mm-next but
> was dropped because of testing failures. I'm still very new to all of
> this process.

Yeah, because do_mounts_initrd.c didn't compile. If you do add it to a
header, use a header local in the init directory. Do not expose
envp_init to the entire kernel.

-- Steve