linux-kernel - Re: [PATCH v2 2/2] serdev: only match serdev devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180119110726.ot76nyctgd2hy64b@earth.universe>
Date:   Fri, 19 Jan 2018 12:07:26 +0100
From:   Sebastian Reichel <sre@...nel.org>
To:     Johan Hovold <johan@...nel.org>
Cc:     Rob Herring <robh@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jslaby@...e.com>, linux-serial@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Frédéric Danis 
        <frederic.danis.oss@...il.com>, Hans de Goede <hdegoede@...hat.com>
Subject: Re: [PATCH v2 2/2] serdev: only match serdev devices

Hi,

On Tue, Jan 09, 2018 at 05:09:17PM +0100, Johan Hovold wrote:
> Only serdev devices (a.k.a. clients or slaves) are bound to drivers so
> bail out early from match() in case the device is not a serdev device
> (i.e. if it's a serdev controller).
> 
> Signed-off-by: Johan Hovold <johan@...nel.org>
> ---

Reviewed-by: Sebastian Reichel <sebastian.reichel@...labora.co.uk>

-- Sebastian

>  drivers/tty/serdev/core.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/tty/serdev/core.c b/drivers/tty/serdev/core.c
> index c8c43834477b..f710862f5c06 100644
> --- a/drivers/tty/serdev/core.c
> +++ b/drivers/tty/serdev/core.c
> @@ -63,6 +63,11 @@ static const struct device_type serdev_device_type = {
>  	.release	= serdev_device_release,
>  };
>  
> +static bool is_serdev_device(const struct device *dev)
> +{
> +	return dev->type == &serdev_device_type;
> +}
> +
>  static void serdev_ctrl_release(struct device *dev)
>  {
>  	struct serdev_controller *ctrl = to_serdev_controller(dev);
> @@ -76,6 +81,9 @@ static const struct device_type serdev_ctrl_type = {
>  
>  static int serdev_device_match(struct device *dev, struct device_driver *drv)
>  {
> +	if (!is_serdev_device(dev))
> +		return 0;
> +
>  	/* TODO: platform matching */
>  	if (acpi_driver_match_device(dev, drv))
>  		return 1;
> -- 
> 2.15.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)