linux-kernel - Re: [PATCH v17 00/10] Add backlight helper functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 19 Jan 2018 11:18:08 +0000
From:   Daniel Thompson <daniel.thompson@...aro.org>
To:     Meghana Madhyastha <meghana.madhyastha@...il.com>
Cc:     Lee Jones <lee.jones@...aro.org>,
        Jingoo Han <jingoohan1@...il.com>,
        Thierry Reding <thierry.reding@...il.com>,
        Noralf Trønnes <noralf@...nnes.org>,
        Tomi Valkeinen <tomi.valkeinen@...com>,
        Daniel Vetter <daniel.vetter@...el.com>,
        Sean Paul <seanpaul@...omium.org>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v17 00/10] Add backlight helper functions

On Fri, Jan 19, 2018 at 10:37:58AM +0000, Meghana Madhyastha wrote:
> Move drm helper functions from tinydrm-helpers to linux/backlight for
> ease of use by callers in other drivers.
> 
> changes in v17:
> -set fb_blank along with clearing the BL_CORE_FBBLANK bit 
> -rebase with drm-misc-next
> -fix checkpath errors/warnings
> -Make the gpio_backlight issue appear as a comment in the
>  code and not as part of the docs
> -rebase with drm-misc-next
> -convert st7735r callers from tinydrm specific helpers
>  to new generic backlight helpers
> -remove select BACKLIGHT_LCD_SUPPORT and select 
>  BACKLIGHT_CLASS_DEVICE from tinydrm/Kconfig
> -fix checkpath errors/warnings
> -rename devm_backlight_put to 
>  devm_backlight_release
> -remove redundant NULL check
> -remove put_device() to avoid double put 
>  as we are using the devm version
> 
> Meghana Madhyastha (10):
>   video: backlight: Add helpers to enable and disable backlight
>   drm/tinydrm: Convert tinydrm_enable/disable_backlight to
>     backlight_enable/disable
>   video: backlight: Add of_find_backlight helper in backlight.c
>   drm/tinydrm: Replace tinydrm_of_find_backlight with of_find_backlight
>   video: backlight: Add devres versions of of_find_backlight
>   drm/tinydrm: Call devres version of of_find_backlight
>   drm/panel: Use backlight_enable/disable helpers
>   drm/omapdrm: Use backlight_enable/disable helpers
>   drm/panel: Use of_find_backlight helper
>   drm/omapdrm: Use of_find_backlight helper

So, I've acked all the backlight bits (if there's a v18 please include
the acks in the posting).

I've read the other patches and I *like* them. Switching to 
backlight_enable()/disable() looks like a good way to ensure
drivers don't interact with all those flags in unexpected ways
(so its a good contribution to eventually cleaning them up).


Daniel.


> 
>  drivers/gpu/drm/omapdrm/displays/panel-dpi.c    | 32 ++-------
>  drivers/gpu/drm/panel/panel-innolux-p079zca.c   | 29 ++------
>  drivers/gpu/drm/panel/panel-jdi-lt070me05000.c  |  6 +-
>  drivers/gpu/drm/panel/panel-sharp-lq101r1sx01.c | 35 ++-------
>  drivers/gpu/drm/panel/panel-sharp-ls043t1le01.c | 35 ++-------
>  drivers/gpu/drm/tinydrm/Kconfig                 |  2 -
>  drivers/gpu/drm/tinydrm/core/tinydrm-helpers.c  | 95 -------------------------
>  drivers/gpu/drm/tinydrm/mi0283qt.c              |  3 +-
>  drivers/gpu/drm/tinydrm/mipi-dbi.c              |  4 +-
>  drivers/gpu/drm/tinydrm/st7735r.c               |  3 +-
>  drivers/video/backlight/backlight.c             | 73 +++++++++++++++++++
>  include/drm/tinydrm/tinydrm-helpers.h           |  4 --
>  include/linux/backlight.h                       | 58 +++++++++++++++
>  13 files changed, 164 insertions(+), 215 deletions(-)
> 
> -- 
> 2.11.0
>