linux-kernel - Re: [PATCH] drm/vmwgfx: Return boolean instead of integer in vmw_fence_obj

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c967cc37-eb21-36dc-add5-ba6bc0150b5f@vmware.com>
Date:   Fri, 19 Jan 2018 13:40:39 +0100
From:   Thomas Hellstrom <thellstrom@...are.com>
To:     "Gustavo A. R. Silva" <garsilva@...eddedor.com>,
        VMware Graphics <linux-graphics-maintainer@...are.com>,
        Sinclair Yeh <syeh@...are.com>, David Airlie <airlied@...ux.ie>
Cc:     dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/vmwgfx: Return boolean instead of integer in
 vmw_fence_obj_signaled

On 01/19/2018 01:02 AM, Gustavo A. R. Silva wrote:
> Return statements in functions returning bool should use
> true/false instead of 1/0.
>
> This issue was detected with the help of Coccinelle.
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com>
Reviewed-by: Thomas Hellström <thellstrom@...are.com>

I'll queue this for 4.17.

Thanks,
Thomas




> ---
>   drivers/gpu/drm/vmwgfx/vmwgfx_fence.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c b/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c
> index 6c5c75c..35fd6f9 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c
> @@ -496,7 +496,7 @@ bool vmw_fence_obj_signaled(struct vmw_fence_obj *fence)
>   	struct vmw_fence_manager *fman = fman_from_fence(fence);
>   
>   	if (test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->base.flags))
> -		return 1;
> +		return true;
>   
>   	vmw_fences_update(fman);
>