linux-kernel - Re: [PATCH] pinctrl: meson-axg: adjust uart_ao

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7hzi59wtdc.fsf@baylibre.com>
Date:   Fri, 19 Jan 2018 11:17:35 -0800
From:   Kevin Hilman <khilman@...libre.com>
To:     Yixun Lan <yixun.lan@...ogic.com>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Neil Armstrong <narmstrong@...libre.com>,
        Jerome Brunet <jbrunet@...libre.com>,
        Carlo Caione <carlo@...one.org>,
        Xingyu Chen <xingyu.chen@...ogic.com>,
        <linux-gpio@...r.kernel.org>, <linux-amlogic@...ts.infradead.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pinctrl: meson-axg: adjust uart_ao_b pin group naming

Yixun Lan <yixun.lan@...ogic.com> writes:

> Simply adjust the pin group to _x _y _z style, as to
> keep the consistency in DT with previous naming scheme.
>
> Fixes: 83c566806a68 ("pinctrl: meson-axg: Add new pinctrl driver for Meson AXG SoC")
> Signed-off-by: Yixun Lan <yixun.lan@...ogic.com>

Reviewed-by: Kevin Hilman <khilman@...libre.com>

Thanks for cleaning this up before we have any DT users.

Kevin

> ---
> Hi Linus,
>
>  Please also consider merging this patch into 'for-next', since it
> fixes issue added in the same cycle.
>  This patch will also obsolete previous one patches [1]
>
> [1] pinctrl: meson: use one uniform 'function' name
> http://lkml.kernel.org/r/20180108073328.205769-1-yixun.lan@amlogic.com
> ---
>  drivers/pinctrl/meson/pinctrl-meson-axg.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/meson/pinctrl-meson-axg.c b/drivers/pinctrl/meson/pinctrl-meson-axg.c
> index 1fda9d6c7ea3..4b91ff74779b 100644
> --- a/drivers/pinctrl/meson/pinctrl-meson-axg.c
> +++ b/drivers/pinctrl/meson/pinctrl-meson-axg.c
> @@ -716,7 +716,7 @@ static const char * const uart_b_groups[] = {
>  	"uart_tx_b_x", "uart_rx_b_x", "uart_cts_b_x", "uart_rts_b_x",
>  };
>  
> -static const char * const uart_ao_b_gpioz_groups[] = {
> +static const char * const uart_ao_b_z_groups[] = {
>  	"uart_ao_tx_b_z", "uart_ao_rx_b_z",
>  	"uart_ao_cts_b_z", "uart_ao_rts_b_z",
>  };
> @@ -855,7 +855,7 @@ static struct meson_pmx_func meson_axg_periphs_functions[] = {
>  	FUNCTION(nand),
>  	FUNCTION(uart_a),
>  	FUNCTION(uart_b),
> -	FUNCTION(uart_ao_b_gpioz),
> +	FUNCTION(uart_ao_b_z),
>  	FUNCTION(i2c0),
>  	FUNCTION(i2c1),
>  	FUNCTION(i2c2),