linux-kernel - Re: [PATCH] smc: return boolean instead of integer in using

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180119144903.Horde.tbajXZQzjH9kwd_yYPMI5mo@gator4166.hostgator.com>
Date:   Fri, 19 Jan 2018 14:49:03 -0600
From:   "Gustavo A. R. Silva" <garsilva@...eddedor.com>
To:     Ursula Braun <ubraun@...ux.vnet.ibm.com>
Cc:     "David S. Miller" <davem@...emloft.net>,
        linux-s390@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] smc: return boolean instead of integer in using_ipsec

Hi Ursula,

Quoting Ursula Braun <ubraun@...ux.vnet.ibm.com>:

> On 01/19/2018 12:33 AM, Gustavo A. R. Silva wrote:
>> Return statements in functions returning bool should use
>> true/false instead of 1/0.
>>
>> This issue was detected with the help of Coccinelle.
>>
>> Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com>
>> ---
>>  net/smc/smc.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/net/smc/smc.h b/net/smc/smc.h
>> index 0bee9d1..ef13af4 100644
>> --- a/net/smc/smc.h
>> +++ b/net/smc/smc.h
>> @@ -258,7 +258,7 @@ static inline bool using_ipsec(struct smc_sock *smc)
>>  #else
>>  static inline bool using_ipsec(struct smc_sock *smc)
>>  {
>> -	return 0;
>> +	return false;
>>  }
>>  #endif
>>
>
> Gustavo,
> thanks for reporting, but your improvement seems to be incomplete.  
> Besides changing
> line 260 of net/smc/smc.h, line 255 should be adapted the same way. Will you
> come up with a second patch version here?
>

You are correct. I'll send a new patch shortly.

Thanks for the feedback.
--
Gustavo