linux-kernel - Re: [PATCH v2] dt-bindings: display: stm32: add pixel clock mandatory property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 19 Jan 2018 16:43:35 -0600
From:   Rob Herring <robh@...nel.org>
To:     Philippe Cornu <philippe.cornu@...com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Russell King <linux@...linux.org.uk>,
        Mark Rutland <mark.rutland@....com>,
        Archit Taneja <architt@...eaurora.org>,
        Andrzej Hajda <a.hajda@...sung.com>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        David Airlie <airlied@...ux.ie>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        Benjamin Gaignard <benjamin.gaignard@...aro.org>,
        Bhumika Goyal <bhumirks@...il.com>, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        Yannick Fertre <yannick.fertre@...com>,
        Vincent Abriou <vincent.abriou@...com>,
        Alexandre Torgue <alexandre.torgue@...com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Gabriel Fernandez <gabriel.fernandez@...com>,
        Ludovic Barre <ludovic.barre@...com>,
        Fabien Dessenne <fabien.dessenne@...com>,
        Mickael Reulier <mickael.reulier@...com>
Subject: Re: [PATCH v2] dt-bindings: display: stm32: add pixel clock
 mandatory property

On Fri, Jan 12, 2018 at 04:30:34PM +0100, Philippe Cornu wrote:
> Add the DPI/RGB input pixel clock in mandatory properties
> because it really offers a better preciseness for timing
> computations.
> Note: Fix also the DSI panel example where "ref" & "pclk"
> clocks were swapped.
> 
> Signed-off-by: Philippe Cornu <philippe.cornu@...com>
> ---
> Changes in v2: put new clock in last position (Rob Herring)
> 
>  Documentation/devicetree/bindings/display/st,stm32-ltdc.txt | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt b/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt
> index 029252253ad4..942b7237ae87 100644
> --- a/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt
> +++ b/Documentation/devicetree/bindings/display/st,stm32-ltdc.txt
> @@ -29,6 +29,7 @@ Mandatory properties specific to STM32 DSI:
>  - compatible: "st,stm32-dsi".
>  - clock-names:
>    - phy pll reference clock string name, must be "ref".
> +  - DPI/RGB input pixel clock string name, must be "px_clk".
>  - resets: see [5].
>  - reset-names: see [5].
>  
> @@ -97,8 +98,9 @@ Example 2: DSI panel
>  			#size-cells = <0>;
>  			compatible = "st,stm32-dsi";
>  			reg = <0x40016c00 0x800>;
> -			clocks = <&rcc 1 CLK_F469_DSI>, <&clk_hse>;
> -			clock-names = "ref", "pclk";
> +			clocks = <&rcc 1 CLK_F469_DSI>, <&clk_hse>,
> +				 <&rcc 1 CLK_LCD>;
> +			clock-names = "pclk", "ref", "px_clk";

You have the existing names reversed here.

>  			resets = <&rcc STM32F4_APB2_RESET(DSI)>;
>  			reset-names = "apb";
>  
> -- 
> 2.15.1
>