linux-kernel - Re: [PATCH 2/2] mm: Fix devm_memremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPcyv4gDpaJZeM0UULLdXU4YPXQUhDfZAzs8xyrXp89AbE-tSg@mail.gmail.com>
Date:   Fri, 19 Jan 2018 16:15:53 -0800
From:   Dan Williams <dan.j.williams@...el.com>
To:     Jan H. Schönherr <jschoenh@...zon.de>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Linux MM <linux-mm@...ck.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] mm: Fix devm_memremap_pages() collision handling

On Wed, Jan 17, 2018 at 4:06 PM, Jan H. Schönherr <jschoenh@...zon.de> wrote:
> If devm_memremap_pages() detects a collision while adding entries
> to the radix-tree, we call pgmap_radix_release(). Unfortunately,
> the function removes *all* entries for the range -- including the
> entries that caused the collision in the first place.
>
> Modify pgmap_radix_release() to take an additional argument to
> indicate where to stop, so that only newly added entries are removed
> from the tree.
>
> Fixes: 9476df7d80df ("mm: introduce find_dev_pagemap()")
> Signed-off-by: Jan H. Schönherr <jschoenh@...zon.de>

Looks good to me, applied for 4.16.