linux-kernel - Re: [PATCH v4 3/3] arm64: allwinner: a64: bananapi-m64: add usb otg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGb2v64zruX9DMc4-y_=rcoYO0XsgcjoQt2LGhmyKCKi+Xc10A@mail.gmail.com>
Date:   Sat, 20 Jan 2018 14:53:43 +0800
From:   Chen-Yu Tsai <wens@...e.org>
To:     Jagan Teki <jagan@...rulasolutions.com>
Cc:     Maxime Ripard <maxime.ripard@...e-electrons.com>,
        Icenowy Zheng <icenowy@...c.io>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will.deacon@....com>,
        Michael Trimarchi <michael@...rulasolutions.com>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        devicetree <devicetree@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        linux-sunxi <linux-sunxi@...glegroups.com>
Subject: Re: [PATCH v4 3/3] arm64: allwinner: a64: bananapi-m64: add usb otg

On Fri, Jan 12, 2018 at 2:30 PM, Jagan Teki <jagan@...rulasolutions.com> wrote:
> Add usb otg support for bananapi-m64 board,
> - USB-ID connected with PH9
> - USB-DRVVBUS controlled by N_VBUSEN pin from PMIC
>
> Signed-off-by: Jagan Teki <jagan@...rulasolutions.com>
> ---
> Changes for v4:
> - rebase on master
> - tested otg host mode.
> Changes for v3:
> - Move the position of reg_drivevbus as per binding documentation.
> Changes for v2:
> - add drvvbus regulator
> - add N_VBUSEN pin
>
>  .../boot/dts/allwinner/sun50i-a64-bananapi-m64.dts  | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
> index a697567..26e8534 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-bananapi-m64.dts
> @@ -86,6 +86,10 @@
>         };
>  };
>
> +&ehci0 {
> +       status = "okay";
> +};
> +
>  &ehci1 {
>         status = "okay";
>  };
> @@ -156,6 +160,10 @@
>         status = "okay";
>  };
>
> +&ohci0 {
> +       status = "okay";
> +};
> +
>  &ohci1 {
>         status = "okay";
>  };
> @@ -168,6 +176,7 @@
>                 reg = <0x3a3>;
>                 interrupt-parent = <&r_intc>;
>                 interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
> +               x-powers,drive-vbus-en; /* set N_VBUSEN as output pin */
>         };
>  };
>
> @@ -283,6 +292,11 @@
>         regulator-name = "vcc-rtc";
>  };
>
> +&reg_drivevbus {

Please keep the nodes in alphabetical order. Otherwise,

Reviewed-by: Chen-Yu Tsai <wens@...e.org>

> +       regulator-name = "usb0-vbus";
> +       status = "okay";
> +};
> +
>  &uart0 {
>         pinctrl-names = "default";
>         pinctrl-0 = <&uart0_pins_a>;
> @@ -295,6 +309,13 @@
>         status = "okay";
>  };
>
> +&usb_otg {
> +       dr_mode = "otg";
> +       status = "okay";
> +};
> +
>  &usbphy {
> +       usb0_id_det-gpios = <&pio 7 9 GPIO_ACTIVE_HIGH>; /* PH9 */
> +       usb0_vbus-supply = <&reg_drivevbus>;
>         status = "okay";
>  };
> --
> 2.7.4
>