linux-kernel - Re: [PATCH v6 0/9] Renesas Capture Engine Unit (CEU) V4L2 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 21 Jan 2018 10:04:58 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     jacopo mondi <jacopo@...ndi.org>
Cc:     Jacopo Mondi <jacopo+renesas@...ndi.org>,
        laurent.pinchart@...asonboard.com, magnus.damm@...il.com,
        geert@...der.be, hverkuil@...all.nl, mchehab@...nel.org,
        festevam@...il.com, sakari.ailus@....fi, robh+dt@...nel.org,
        mark.rutland@....com, pombredanne@...b.com,
        linux-renesas-soc@...r.kernel.org, linux-media@...r.kernel.org,
        linux-sh@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 0/9] Renesas Capture Engine Unit (CEU) V4L2 driver

On 01/21/2018 09:54 AM, jacopo mondi wrote:
> Hi Randy,
>    thanks for noticing,
> 
> On Fri, Jan 19, 2018 at 02:12:19PM -0800, Randy Dunlap wrote:
>> On 01/16/2018 01:44 PM, Jacopo Mondi wrote:
>>> Hello,
>>>    new version of CEU after Hans' review.
>>>
>>> Added his Acked-by to most patches and closed review comments.
>>> Running v4l2-compliance, I noticed a new failure introduced by the way I now
>>> calculate the plane sizes in set/try_fmt.
>>
>> I would expect that you have already seen this, but I get a build error
>> in renesas-ceu.c.  Here is a small patch for it.
> 
> Actually I did not.
> The compile error has been introduced by this commit
> 
> commit 4e48afecd5ee3a394d228349fc1c33982e9fb557
> Author: Mauro Carvalho Chehab <mchehab@...pensource.com>
> Date:   Wed Sep 27 10:12:00 2017 -0400
>         media: v4l2-async: simplify v4l2_async_subdev structure
> 
> Which is not in v4.15-rc8 on which I have based my work on.
> 
> As a general question, if I'm aiming to have my driver included in
> next release, should I always base my work on linux-next or it depends
> on sub-system/maintainers preferences?

That's up to the subsystem maintainer, but usually you should make sure
that it will apply to linux-next or to the subsystem's "-next" tree,
whatever that is called.

>>
>> ---
>> From: Randy Dunlap <rdunlap@...radead.org>
>>
>> Fix build error (on x86 with COMPILE_TEST):
>>
>> ../drivers/media/platform/renesas-ceu.c: In function 'ceu_parse_dt':
>> ../drivers/media/platform/renesas-ceu.c:1497:27: error: request for member 'fwnode' in something not a structure or union
>>    ceu_sd->asd.match.fwnode.fwnode =
>>
>> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
>> ---
>>  drivers/media/platform/renesas-ceu.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --- linux-next-20180119.orig/drivers/media/platform/renesas-ceu.c
>> +++ linux-next-20180119/drivers/media/platform/renesas-ceu.c
>> @@ -1494,7 +1494,7 @@ static int ceu_parse_dt(struct ceu_devic
>>
>>  		ceu_sd->mbus_flags = fw_ep.bus.parallel.flags;
>>  		ceu_sd->asd.match_type = V4L2_ASYNC_MATCH_FWNODE;
>> -		ceu_sd->asd.match.fwnode.fwnode =
>> +		ceu_sd->asd.match.fwnode =
>>  			fwnode_graph_get_remote_port_parent(
>>  					of_fwnode_handle(ep));
>>
>>


-- 
~Randy