linux-kernel - Re: [PATCH v17 06/10] drm/tinydrm: Call devres version of of_find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <14d3b5a4-cf3a-5962-e939-2a09bdee5c9d@tronnes.org>
Date:   Sun, 21 Jan 2018 19:42:57 +0100
From:   Noralf Trønnes <noralf@...nnes.org>
To:     Meghana Madhyastha <meghana.madhyastha@...il.com>,
        Lee Jones <lee.jones@...aro.org>,
        Daniel Thompson <daniel.thompson@...aro.org>,
        Jingoo Han <jingoohan1@...il.com>,
        Thierry Reding <thierry.reding@...il.com>,
        Tomi Valkeinen <tomi.valkeinen@...com>,
        Daniel Vetter <daniel.vetter@...el.com>,
        Sean Paul <seanpaul@...omium.org>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v17 06/10] drm/tinydrm: Call devres version of
 of_find_backlight


Den 19.01.2018 11.46, skrev Meghana Madhyastha:
> Call devm_of_find_backlight (the devres version) instead of
> of_find_backlight.
>
> Signed-off-by: Meghana Madhyastha <meghana.madhyastha@...il.com>
> ---

I already put my r-b on this one in the previous version, but now also:

Tested-by: Noralf Trønnes <noralf@...nnes.org>

I did also test with the backlight subsystem disabled.

> changes in v17:
> -convert st7735r callers from tinydrm specific helpers
>   to new generic backlight helpers
>
>   drivers/gpu/drm/tinydrm/mi0283qt.c | 2 +-
>   drivers/gpu/drm/tinydrm/st7735r.c  | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/tinydrm/mi0283qt.c b/drivers/gpu/drm/tinydrm/mi0283qt.c
> index a8aafce36..d8ed6e6f8 100644
> --- a/drivers/gpu/drm/tinydrm/mi0283qt.c
> +++ b/drivers/gpu/drm/tinydrm/mi0283qt.c
> @@ -196,7 +196,7 @@ static int mi0283qt_probe(struct spi_device *spi)
>   	if (IS_ERR(mipi->regulator))
>   		return PTR_ERR(mipi->regulator);
>   
> -	mipi->backlight = of_find_backlight(dev);
> +	mipi->backlight = devm_of_find_backlight(dev);
>   	if (IS_ERR(mipi->backlight))
>   		return PTR_ERR(mipi->backlight);
>   
> diff --git a/drivers/gpu/drm/tinydrm/st7735r.c b/drivers/gpu/drm/tinydrm/st7735r.c
> index 2e6b7b8ec..67d197ecf 100644
> --- a/drivers/gpu/drm/tinydrm/st7735r.c
> +++ b/drivers/gpu/drm/tinydrm/st7735r.c
> @@ -164,7 +164,7 @@ static int st7735r_probe(struct spi_device *spi)
>   		return PTR_ERR(dc);
>   	}
>   
> -	mipi->backlight = of_find_backlight(dev);
> +	mipi->backlight = devm_of_find_backlight(dev);
>   	if (IS_ERR(mipi->backlight))
>   		return PTR_ERR(mipi->backlight);
>