linux-kernel - Re: [PATCH] Input: trackpoint - force 3 buttons if 0 button is reported

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <051BA339-04DD-4AF7-B7CA-BBB5401053D8@gmail.com>
Date:   Sun, 21 Jan 2018 13:14:58 -0800
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     ulrik.debie-os@...ig.org
CC:     Aaron Ma <aaron.ma@...onical.com>, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Input: trackpoint - force 3 buttons if 0 button is reported

On January 21, 2018 12:10:50 PM PST, ulrik.debie-os@...ig.org wrote:
>On Tue, Jan 16, 2018 at 03:07:13PM -0800, Dmitry Torokhov wrote:
>Hi Dmitry,
>
>> 
>> On Sat, Jan 13, 2018 at 10:34:19AM +0800, Aaron Ma wrote:
>> > Will your patch go to stable kernel?
>> > If yes, that's fine.
>> 
>> Hmm, it looks like we need this patch after all as we do have screwy
>> Lenovos with apparently 0x01 devices reporting 0 buttons. From
>> https://bugzilla.kernel.org/show_bug.cgi?id=196253
>> 
>>  thinkpad_acpi: ThinkPad BIOS R0DET87W (1.87 ), EC unknown
>>  thinkpad_acpi: Lenovo ThinkPad E470, model 20H1004SGE
>> 
>>  psmouse serio2: trackpoint: IBM TrackPoint firmware: 0x0e, buttons:
>0/0
>> 
>> I'll ask them to try my patch and if it is indeed 0x01 device I'll
>apply
>> your patch.
>
>It is quite strange. In the past,for commit 293b915fd9be 
>"Input: trackpoint - assume 3 buttons when buttons detection fails"
>there was
>success reported for lenovo e470 and I see the same success report in
>that
>bugzilla ticket.  I can also report success on lenovo e570.
>
>But some seem to have problems, could it be that they are not including
>that
>commit in the kernel they are running ? Or did a bios upgrade change
>the
>behaviour ?
>It would be best when we have a confirmation from a e470 owner that
>without the
>proposed patch from Aaron the middle button does not work on his e470,
>and it
>works with it.

I suppose Lenovo changed the firmware, because if you take a look at bugzilla link I provided there is a box that does not fail the command but indeed responds with 0 as number of buttons. It still reports device ID 0x010e.

Hi Ulrik,
Thanks.

-- 
Dmitry