linux-kernel - Re: [PATCH 4.4 39/63] net: reevalulate autoflowlabel setting after sysctl setting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1516575958.3417.22.camel@codethink.co.uk>
Date:   Sun, 21 Jan 2018 23:05:58 +0000
From:   Ben Hutchings <ben.hutchings@...ethink.co.uk>
To:     Shaohua Li <shli@...com>
Cc:     stable@...r.kernel.org, Martin KaFai Lau <kafai@...com>,
        Eric Dumazet <eric.dumazet@...il.com>,
        Tom Herbert <tom@...ntonium.net>,
        "David S. Miller" <davem@...emloft.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4.4 39/63] net: reevalulate autoflowlabel setting after
 sysctl setting

On Mon, 2018-01-01 at 15:24 +0100, Greg Kroah-Hartman wrote:
> 4.4-stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Shaohua Li <shli@...com>
> 
> 
> [ Upstream commit 513674b5a2c9c7a67501506419da5c3c77ac6f08 ]
[...]
> Note, this changes behavior a little bit. Before commit 42240901f7c4
> (ipv6: Implement different admin modes for automatic flow labels), the
> autoflowlabel behavior of a sock isn't sticky, eg, if sysctl changes,
> existing connection will change autoflowlabel behavior. After that
> commit, autoflowlabel behavior is sticky in the whole life of the sock.
> With this patch, the behavior isn't sticky again.
[...]

I think the getsockopt() handling for IPV6_AUTOFLOWLABEL also needs to
be updated, as it will now return 0 unless the option has been
explicitly set.

Ben.

-- 
Ben Hutchings
Software Developer, Codethink Ltd.