linux-kernel - Re: [PATCH] x86: Use __nostackprotect for sme_encrypt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180121095020.72syevzzeekf7q3x@gmail.com>
Date:   Sun, 21 Jan 2018 10:50:20 +0100
From:   Ingo Molnar <mingo@...nel.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        Gabriel C <nix.or.die@...il.com>,
        Laura Abbott <labbott@...hat.com>,
        Tom Lendacky <thomas.lendacky@....com>,
        Borislav Petkov <bp@...e.de>,
        Peter Zijlstra <peterz@...radead.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Brijesh Singh <brijesh.singh@....com>, X86 ML <x86@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        stable <stable@...r.kernel.org>
Subject: Re: [PATCH] x86: Use __nostackprotect for sme_encrypt_kernel


* Greg Kroah-Hartman <gregkh@...uxfoundation.org> wrote:

> On Sat, Jan 20, 2018 at 08:16:31PM -0800, Linus Torvalds wrote:
> > On Sat, Jan 20, 2018 at 5:49 PM, Gabriel C <nix.or.die@...il.com> wrote:
> > >
> > > Added stable to CC since the patch series this patch fixes
> > > is in stable-queue.
> > 
> > Oh, it wasn't clear from the commit message. But I guess the "Fixes:"
> > tag would have caught Greg's eye regardless.
> 
> Ugh, I am _so_ behind in looking at patches that only have a Fixes: tag
> in it and not a "Cc: stable@" tag, due to the recent high-volume of the
> latter.
> 
> But they will end up in a mbox that I need to dig out of eventually, but
> it will take time, so if you know you want a patch in a stable release,
> it's much easier to just use the "Cc: stable@" tag please.

Just to make it easier, please put this upstream fix into -stable:

  91cfc88c66bf: ("x86: Use __nostackprotect for sme_encrypt_kernel")

I believe all the prerequisite upstream commits are in -stable already:

 1303880179e6: x86/mm: Clean up register saving in the __enc_copy() assembly code
 bacf6b499e11: x86/mm: Use a struct to reduce parameters for SME PGD mapping
 2b5d00b6c2cd: x86/mm: Centralize PMD flags in sme_encrypt_kernel()
 cc5f01e28d6c: x86/mm: Prepare sme_encrypt_kernel() for PAGE aligned encryption
 107cd2532181: x86/mm: Encrypt the initrd earlier for BSP microcode update

Thanks,

	Ingo