linux-kernel - Re: [PATCH v11 1/9] LIB: Introduce a generic PIO mapping method

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201801212144.Pmg8hBdB%fengguang.wu@intel.com>
Date:   Sun, 21 Jan 2018 21:29:08 +0800
From:   kbuild test robot <lkp@...el.com>
To:     John Garry <john.garry@...wei.com>
Cc:     kbuild-all@...org, mika.westerberg@...ux.intel.com,
        rafael@...nel.org, lorenzo.pieralisi@....com, rjw@...ysocki.net,
        robh+dt@...nel.org, bhelgaas@...gle.com, arnd@...db.de,
        mark.rutland@....com, olof@...om.net, hanjun.guo@...aro.org,
        dann.frazier@...onical.com, benh@...nel.crashing.org,
        linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org,
        linuxarm@...wei.com, linux-pci@...r.kernel.org, minyard@....org,
        devicetree@...r.kernel.org, linux-arch@...r.kernel.org,
        Zhichang Yuan <yuanzhichang@...ilicon.com>,
        Gabriele Paoloni <gabriele.paoloni@...wei.com>,
        John Garry <john.garry@...wei.com>
Subject: Re: [PATCH v11 1/9] LIB: Introduce a generic PIO mapping method

Hi Zhichang,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v4.15-rc8 next-20180119]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/John-Garry/LPC-legacy-ISA-I-O-support/20180121-194832
config: i386-randconfig-a1-201803 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All warnings (new ones prefixed by >>):

   lib/logic_pio.c: In function 'logic_pio_trans_hwaddr':
>> lib/logic_pio.c:175:3: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 2 has type 'resource_size_t' [-Wformat=]
      pr_err("resource size 0x%llx cannot fit in IO range size 0x%llx\n",
      ^
   lib/logic_pio.c:175:3: warning: format '%llx' expects argument of type 'long long unsigned int', but argument 3 has type 'resource_size_t' [-Wformat=]

vim +175 lib/logic_pio.c

   157	
   158	/*
   159	 * This function is generic for translating a hardware address to logical PIO.
   160	 * @hw_addr: the hardware address of host, can be CPU address or host-local
   161	 *		address;
   162	 */
   163	unsigned long
   164	logic_pio_trans_hwaddr(struct fwnode_handle *fwnode, resource_size_t addr,
   165			       resource_size_t size)
   166	{
   167		struct logic_pio_hwaddr *range;
   168	
   169		range = find_io_range_by_fwnode(fwnode);
   170		if (!range || range->flags == PIO_CPU_MMIO) {
   171			pr_err("range not found or invalid\n");
   172			return -1;
   173		}
   174		if (range->size < size) {
 > 175			pr_err("resource size 0x%llx cannot fit in IO range size 0x%llx\n",
   176			       size, range->size);
   177			return -1;
   178		}
   179		return addr - range->hw_start + range->io_start;
   180	}
   181	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (29428 bytes)