linux-kernel - Re: [PATCH v4 08/13] iommu/rockchip: Control clocks needed to access the IOMMU

Open Source and information security mailing list archives

Message-ID: <1f4b3c0d-1414-0012-a072-f4a11f432c21@rock-chips.com>
Date:   Mon, 22 Jan 2018 09:18:09 +0800
From:   Randy Li <randy.li@...k-chips.com>
To:     JeffyChen <jeffy.chen@...k-chips.com>,
        Robin Murphy <robin.murphy@....com>,
        linux-kernel@...r.kernel.org, tfiga@...omium.org
Cc:     Mark Rutland <mark.rutland@....com>, devicetree@...r.kernel.org,
        xxm@...k-chips.com, Joerg Roedel <joro@...tes.org>,
        jcliang@...omium.org, linux-rockchip@...ts.infradead.org,
        iommu@...ts.linux-foundation.org, Rob Herring <robh+dt@...nel.org>,
        linux-arm-kernel@...ts.infradead.org,
        Heiko Stuebner <heiko@...ech.de>
Subject: Re: [PATCH v4 08/13] iommu/rockchip: Control clocks needed to access
 the IOMMU


On 01/18/2018 10:25 PM, JeffyChen wrote:
> Hi Robin,
> 
> On 01/18/2018 08:27 PM, Robin Murphy wrote:
>>>
>>
>> Is it worth using the clk_bulk_*() APIs for this? At a glance, most of
>> the code being added here appears to duplicate what those functions
>> already do (but I'm no clk API expert, for sure).
> right, i think it's doable, the clk_bulk APIs are very helpful. i think 
> we didn't use that is because this patch were wrote for the chromeos 4.4 
> kernel, which doesn't have clk_bulk yet:)
> 
> will do it in the next version, thanks.
Also the power domain driver could manage the clocks as well, I would 
suggest to use pm_runtime_*.
>>
>> Robin.
> 
> 
> 
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
> 

-- 
Randy Li

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives