linux-kernel - Re: [PATCH][next] devlink: fix memory leak on 'resource'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180122103412.GB2012@nanopsycho>
Date:   Mon, 22 Jan 2018 11:34:12 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Colin King <colin.king@...onical.com>
Cc:     Arkadi Sharshevsky <arkadis@...lanox.com>,
        Jiri Pirko <jiri@...lanox.com>,
        "David S . Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] devlink: fix memory leak on 'resource'

Mon, Jan 22, 2018 at 11:31:19AM CET, colin.king@...onical.com wrote:
>From: Colin Ian King <colin.king@...onical.com>
>
>Currently, if the call to devlink_resource_find returns null then
>the error exit path does not free the devlink_resource 'resource'
>and a memory leak occurs. Fix this by kfree'ing resource on the
>error exit path.
>
>Detected by CoverityScan, CID#1464184 ("Resource leak")
>
>Fixes: d9f9b9a4d05f ("devlink: Add support for resource abstraction")
>Signed-off-by: Colin Ian King <colin.king@...onical.com>

Acked-by: Jiri Pirko <jiri@...lanox.com>

Thanks.