linux-kernel - Re: [PATCH 03/40] drm/rockchip: Respect page offset for PRIME mmap calls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2335179.Wol6YGBpGI@phil>
Date:   Mon, 22 Jan 2018 11:44:25 +0100
From:   Heiko Stuebner <heiko@...ech.de>
To:     linux-rockchip@...ts.infradead.org
Cc:     Thierry Escande <thierry.escande@...labora.com>,
        Archit Taneja <architt@...eaurora.org>,
        Inki Dae <inki.dae@...sung.com>,
        Thierry Reding <thierry.reding@...il.com>,
        Sandy Huang <hjc@...k-chips.com>,
        Sean Paul <seanpaul@...omium.org>,
        David Airlie <airlied@...ux.ie>,
        zain wang <wzz@...k-chips.com>, Lin Huang <hl@...k-chips.com>,
        linux-kernel@...r.kernel.org,
        Douglas Anderson <dianders@...omium.org>,
        dri-devel@...ts.freedesktop.org, Tomasz Figa <tfiga@...omium.org>,
        Yakir Yang <ykk@...k-chips.com>,
        Ørjan Eide <orjan.eide@....com>,
        Mark Yao <mark.yao@...k-chips.com>,
        Haixia Shi <hshi@...omium.org>
Subject: Re: [PATCH 03/40] drm/rockchip: Respect page offset for PRIME mmap calls

Am Montag, 15. Januar 2018, 18:15:37 CET schrieb Thierry Escande:
> From: Ørjan Eide <orjan.eide@....com>
> 
> When mapping external DMA-bufs through the PRIME mmap call, we might be
> given an offset which has to be respected. However for the internal DRM
> GEM mmap path, we have to ignore the fake mmap offset used to identify
> the buffer only. Currently the code always zeroes out vma->vm_pgoff,
> which breaks the former.
> 
> This patch fixes the problem by moving the vm_pgoff assignment to a
> function that is used only for GEM mmap path, so that the PRIME path
> retains the original offset.
> 
> Cc: Daniel Kurtz <djkurtz@...omium.org>
> Signed-off-by: Ørjan Eide <orjan.eide@....com>
> Signed-off-by: Tomasz Figa <tfiga@...omium.org>
> Signed-off-by: Sean Paul <seanpaul@...omium.org>
> Signed-off-by: Thierry Escande <thierry.escande@...labora.com>

On rk3036 + lima and rk3328 + lima
Tested-by: Heiko Stuebner <heiko@...ech.de>