linux-kernel - Re: [PATCH -next] of: platform: fix OF node refcount leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <10e5ef22-37e5-986f-eda0-446214c5626b@arm.com>
Date:   Mon, 22 Jan 2018 11:13:06 +0000
From:   Sudeep Holla <sudeep.holla@....com>
To:     Andy Gross <andy.gross@...aro.org>
Cc:     Sudeep Holla <sudeep.holla@....com>,
        devicetree <devicetree@...r.kernel.org>,
        Linux Kernel list <linux-kernel@...r.kernel.org>,
        Loys Ollivier <lollivier@...libre.com>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Frank Rowand <frowand.list@...il.com>
Subject: Re: [PATCH -next] of: platform: fix OF node refcount leak



On 19/01/18 23:34, Andy Gross wrote:
> On 19 January 2018 at 09:37, Sudeep Holla <sudeep.holla@....com> wrote:
>> Hi Andy,
>>
>> On 18/01/18 10:43, Sudeep Holla wrote:
>>> We need to call of_node_put() for device nodes obtained with
>>> of_find_node_by_path().
>>>
>>> Fixes: 3aa0582fdb82 ("of: platform: populate /firmware/ node from of_platform_default_populate_init()")
>>> Reported-by: Loys Ollivier <lollivier@...libre.com>
>>> Cc: Rob Herring <robh+dt@...nel.org>
>>> Cc: Frank Rowand <frowand.list@...il.com>
>>> Signed-off-by: Sudeep Holla <sudeep.holla@....com>
>>> ---
>>>  drivers/of/platform.c | 4 +++-
>>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>
>> Can you pick up this with other fixes you would send after v4.16-rc1 or
>> do you prefer me to route through ARM-SoC directly ? Let me know.
> 
> I can pick this up for fixes, no problem.  I can send it along right
> now if you like.  This is a pretty low risk patch.
> 

Thanks Andy.

-- 
Regards,
Sudeep