linux-kernel - Re: [PATCH] Support intel-vbtn based tablet mode switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD6_BovWVrbTqBcNE9a=kH9Kk3EzKj7yvz0_Yx0Qat7fzhJTCg@mail.gmail.com>
Date:   Mon, 22 Jan 2018 14:52:47 +0100
From:   Marco Martin <notmart@...il.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Matthew Garrett <mjg59@...f.ucam.org>,
        Pali Rohár <pali.rohar@...il.com>,
        Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        Bhushan Shah <bhush94@...il.com>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        Mario Limonciello <mario.limonciello@...l.com>,
        Mario Limonciello <mario_limonciello@...l.com>
Subject: Re: [PATCH] Support intel-vbtn based tablet mode switch

On Mon, Jan 22, 2018 at 2:42 PM, Andy Shevchenko
<andy.shevchenko@...il.com> wrote:
>
>> +       status = acpi_evaluate_object(handle, "VGBS", NULL, &vgbs_output);
>> +       /* VGBS being present and returning something means
>> +        * we have a tablet mode switch
>> +        */
>> +       if (ACPI_SUCCESS(status)) {
>> +               union acpi_object *obj = vgbs_output.pointer;
>> +
>> +               input_set_capability(priv->input_dev, EV_SW, SW_TABLET_MODE);
>> +
>> +               if (obj && obj->type == ACPI_TYPE_INTEGER) {
>> +                       if (obj->integer.value & TABLET_MODE_FLAG)
>> +                               input_report_switch(priv->input_dev,
>
>> +                                                       SW_TABLET_MODE,
>> +                                                       0);
>
> One line?

checkpatch.pl was complaining about lines too long.

--
Marco Martin