linux-kernel - Re: [PATCH v1] device property: Define type of PROPERTY_ENRTY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3c3d0155-b097-b9dd-ebf9-6698ff47c673@acm.org>
Date:   Mon, 22 Jan 2018 09:47:38 -0600
From:   Corey Minyard <minyard@....org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org,
        "Rafael J . Wysocki" <rafael.j.wysocki@...el.com>,
        Sakari Ailus <sakari.ailus@...ux.intel.com>,
        mika.westerberg@...ux.intel.com
Subject: Re: [PATCH v1] device property: Define type of PROPERTY_ENRTY_*()
 macros

On 01/22/2018 09:33 AM, Andy Shevchenko wrote:
> Some of the drivers may use the macro at runtime flow, like
>
>    struct property_entry p[10];
> ...
>    p[index++] = PROPERTY_ENTRY_U8("u8 property", u8_data);
>
> In that case and absence of the data type compiler fails the build:
>
> drivers/char/ipmi/ipmi_dmi.c:79:29: error: Expected ; at end of statement
> drivers/char/ipmi/ipmi_dmi.c:79:29: error: got {
>
> Cc: Corey Minyard <minyard@....org>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>

This looks good to me.

Acked-by: Corey Minyard <cminyard@...sta.com>

> ---
>   include/linux/property.h | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/include/linux/property.h b/include/linux/property.h
> index 7eefaf2f22b9..f144be4f99e0 100644
> --- a/include/linux/property.h
> +++ b/include/linux/property.h
> @@ -204,7 +204,7 @@ struct property_entry {
>    */
>   
>   #define PROPERTY_ENTRY_INTEGER_ARRAY(_name_, _type_, _Type_, _val_)	\
> -{									\
> +(struct property_entry) {						\
>   	.name = _name_,							\
>   	.length = ARRAY_SIZE(_val_) * sizeof(_type_),			\
>   	.is_array = true,						\
> @@ -222,7 +222,7 @@ struct property_entry {
>   	PROPERTY_ENTRY_INTEGER_ARRAY(_name_, u64, U64, _val_)
>   
>   #define PROPERTY_ENTRY_STRING_ARRAY(_name_, _val_)		\
> -{								\
> +(struct property_entry) {					\
>   	.name = _name_,						\
>   	.length = ARRAY_SIZE(_val_) * sizeof(const char *),	\
>   	.is_array = true,					\
> @@ -231,7 +231,7 @@ struct property_entry {
>   }
>   
>   #define PROPERTY_ENTRY_INTEGER(_name_, _type_, _Type_, _val_)	\
> -{								\
> +(struct property_entry) {					\
>   	.name = _name_,						\
>   	.length = sizeof(_type_),				\
>   	.type = DEV_PROP_##_Type_,				\
> @@ -248,7 +248,7 @@ struct property_entry {
>   	PROPERTY_ENTRY_INTEGER(_name_, u64, U64, _val_)
>   
>   #define PROPERTY_ENTRY_STRING(_name_, _val_)		\
> -{							\
> +(struct property_entry) {				\
>   	.name = _name_,					\
>   	.length = sizeof(_val_),			\
>   	.type = DEV_PROP_STRING,			\
> @@ -256,7 +256,7 @@ struct property_entry {
>   }
>   
>   #define PROPERTY_ENTRY_BOOL(_name_)		\
> -{						\
> +(struct property_entry) {			\
>   	.name = _name_,				\
>   }
>