linux-kernel - Re: [PATCH TRIVIAL] bsg: use pr_debug instead of hand crafted macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8ecbf7d2-b056-cd93-ebf3-b4eaf22f7abe@wdc.com>
Date:   Mon, 22 Jan 2018 08:33:37 -0800
From:   Bart Van Assche <bart.vanassche@....com>
To:     Johannes Thumshirn <jthumshirn@...e.de>, Jens Axboe <axboe@...com>
Cc:     Linux Block Layer Mailinglist <linux-block@...r.kernel.org>,
        Linux Kernel Mailinglist <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH TRIVIAL] bsg: use pr_debug instead of hand crafted macros

On 01/21/18 23:53, Johannes Thumshirn wrote:
> -	dprintk("map hdr %llx/%u %llx/%u\n", (unsigned long long) hdr->dout_xferp,
> +	pr_debug("map hdr %llx/%u %llx/%u\n",
> +		 (unsigned long long) hdr->dout_xferp,
>   		hdr->dout_xfer_len, (unsigned long long) hdr->din_xferp,
>   		hdr->din_xfer_len);

Should the indentation of the arguments have been adjusted?

> @@ -299,7 +292,7 @@ static void bsg_rq_end_io(struct request *rq, blk_status_t status)
>   	struct bsg_device *bd = bc->bd;
>   	unsigned long flags;
>   
> -	dprintk("%s: finished rq %p bc %p, bio %p\n",
> +	pr_debug("%s: finished rq %p bc %p, bio %p\n",
>   		bd->name, rq, bc, bc->bio);

Same question here ...

Thanks,

Bart.