[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20180122164730.GD27216@lst.de>
Date: Mon, 22 Jan 2018 17:47:30 +0100
From: Christoph Hellwig <hch@....de>
To: Al Viro <viro@...IV.linux.org.uk>
Cc: netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
Linus Torvalds <torvalds@...ux-foundation.org>,
linux-kernel@...r.kernel.org, Christoph Hellwig <hch@....de>
Subject: Re: [PATCH 04/10] kill dev_ifsioc()
On Thu, Jan 18, 2018 at 07:37:49PM +0000, Al Viro wrote:
> From: Al Viro <viro@...iv.linux.org.uk>
>
> it's been equivalent to sock_do_ioctl() since 2009...
>
> Signed-off-by: Al Viro <viro@...iv.linux.org.uk>
Note that we have two different dev_ifsioc() defintions, which
is a little weird.
But the net/socket.c one does indeed seem superflous as there is no
point in doing the compat_alloc_user_space / copy_in_user as far
as I can tell. compat_ifreq differs from ifreq in the size of
ifru_data, but it seems none of these ioctls actually use it.
A better changelog would be nice, though.
Powered by blists - more mailing lists