linux-kernel - Re: [PATCH] PCI/ASPM: Suppress common clock mode setting failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9a557c73-ac13-96b3-2eff-6b3a1ccaa7d6@codeaurora.org>
Date:   Mon, 22 Jan 2018 14:13:33 -0500
From:   Sinan Kaya <okaya@...eaurora.org>
To:     linux-pci@...r.kernel.org, timur@...eaurora.org
Cc:     linux-arm-msm@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        Rajat Jain <rajatja@...gle.com>,
        Vidya Sagar <vidyas@...dia.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Kees Cook <keescook@...omium.org>,
        Ard Biesheuvel <ard.biesheuvel@...aro.org>,
        Yinghai Lu <yinghai@...nel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] PCI/ASPM: Suppress common clock mode setting failure

On 1/22/2018 12:28 PM, Sinan Kaya wrote:
> +++ b/drivers/pci/pcie/aspm.c
> @@ -253,6 +253,11 @@ static void pcie_aspm_configure_common_clock(struct pcie_link_state *link)
>  
>  	/* Configure upstream component */
>  	pcie_capability_read_word(parent, PCI_EXP_LNKCTL, &reg16);
> +
> +	/* Port might be already in common clock mode */
> +	if ((same_clock) && (reg16 & PCI_EXP_LNKCTL_CCC))
> +		return;
> +

I think the placement of this statement is too late. I'll move it a couple of lines
and post V2.

-- 
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.