linux-kernel - Re: [PATCH net-next v2] net: core: Expose number of link up/down transitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180122.154318.784941022568373440.davem@davemloft.net>
Date:   Mon, 22 Jan 2018 15:43:18 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     f.fainelli@...il.com
Cc:     netdev@...r.kernel.org, dsahern@...il.com, jiri@...nulli.us,
        cphealy@...il.com, andrew@...n.ch, jakub.kicinski@...ronome.com,
        decot@...glers.com, jhs@...atatu.com, xiyou.wangcong@...il.com,
        daniel@...earbox.net, nikolay@...ulusnetworks.com, ast@...com,
        roopa@...ulusnetworks.com, vyasevich@...il.com, jonas@...thpole.se,
        maheshb@...gle.com, stephen@...workplumber.org,
        ishkamiel@...il.com, fw@...len.de, arvind.yadav.cs@...il.com,
        avagin@...nvz.org, mingo@...nel.org, lucien.xin@...il.com,
        mschiffer@...verse-factory.net, jbenc@...hat.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2] net: core: Expose number of link up/down
 transitions

From: Florian Fainelli <f.fainelli@...il.com>
Date: Thu, 18 Jan 2018 09:59:13 -0800

> From: David Decotigny <decot@...glers.com>
> 
> Expose the number of times the link has been going UP or DOWN, and
> update the "carrier_changes" counter to be the sum of these two events.
> While at it, also update the sysfs-class-net documentation to cover:
> carrier_changes (3.15), carrier_up_count (4.16) and carrier_down_count
> (4.16)
> 
> Signed-off-by: David Decotigny <decot@...glers.com>
> [Florian:
> * rebase
> * add documentation
> * merge carrier_changes with up/down counters]
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
> ---
> Changes in v2:
> - fixed sysfs attributes to use <iface>
> - renamed count_link_{up,down} to carrier_{up,down}_count to match
>   existing carrier_changes semantics

Like David Ahern I am strongly against the proliferation of sysfs files
attached to network devices and the per-netdevice costs associated with
that.

However, dealing with that is a longer term issue that nobody has a clear
plan for.  Therefore I cannot reject this change on that basis alone.

The information is useful, so applied, thanks.