linux-kernel - Report long suspend times of NVMe devices (mostly firmware/device issues)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <9e398971-762d-bb1a-f798-bf0b18cb5b6b@molgen.mpg.de>
Date:   Mon, 22 Jan 2018 22:02:12 +0100
From:   Paul Menzel <pmenzel+linux-nvme@...gen.mpg.de>
To:     Keith Busch <keith.busch@...el.com>, Jens Axboe <axboe@...com>,
        Christoph Hellwig <hch@....de>,
        Sagi Grimberg <sagi@...mberg.me>
Cc:     linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Report long suspend times of NVMe devices (mostly firmware/device
 issues)

Dear Linux folks,


Benchmarking the ACPI S3 suspend and resume times with `sleepgraph.py 
-config config/suspend-callgraph.cfg` [1], shows that the NVMe disk 
SAMSUNG MZVKW512HMJP-00000 in the TUXEDO Book BU1406 takes between 0.3 
and 1.4 seconds, holding up the suspend cycle.

The time is spent in `nvme_shutdown_ctrl()`.

### Linux 4.14.1-041401-generic

> nvme @ 0000:04:00.0 {nvme} async_device (Total Suspend: 1439.299 ms Total Resume: 19.865 ms)

### Linux 4.15-rc9

> nvme @ 0000:04:00.0 {nvme} async_device (Total Suspend: 362.239 ms Total Resume: 19.897 m
It’d be useful, if the Linux kernel logged such issues visibly to the 
user, so that the hardware manufacturer can be contacted to fix the 
device (probably the firmware).

In my opinion anything longer than 200 ms should be reported similar to 
[2], and maybe worded like below.

> NVMe took more than 200 ms to do suspend routine

What do you think?


Kind regards,

Paul


[1] https://github.com/01org/pm-graph
[2] https://patchwork.kernel.org/patch/10135925/

View attachment "20180122–tuxedo_book_bu1406–linux_messages.txt" of type "text/plain" (203735 bytes)