linux-kernel - Re: [PATCH] x86/retpoline: Remove the esp/rsp thunk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1516659707.9521.77.camel@infradead.org>
Date:   Mon, 22 Jan 2018 22:21:47 +0000
From:   David Woodhouse <dwmw2@...radead.org>
To:     Waiman Long <longman@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>
Cc:     linux-kernel@...r.kernel.org,
        Arjan van de Ven <arjan@...ux.intel.com>,
        Andi Kleen <ak@...ux.intel.com>,
        Josh Poimboeuf <jpoimboe@...hat.com>,
        Jeff Law <law@...hat.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Jiri Kosina <jikos@...nel.org>,
        Andy Lutomirski <luto@...capital.net>,
        Dave Hansen <dave.hansen@...el.com>,
        Kees Cook <keescook@...gle.com>,
        Tim Chen <tim.c.chen@...ux.intel.com>,
        Greg Kroah-Hartman <gregkh@...ux-foundation.org>,
        Paul Turner <pjt@...gle.com>,
        Tom Lendacky <thomas.lendacky@....com>
Subject: Re: [PATCH] x86/retpoline: Remove the esp/rsp thunk

On Mon, 2018-01-22 at 17:09 -0500, Waiman Long wrote:
> It doesn't make sense to have an indirect call thunk with esp/rsp as
> retpoline code won't work correctly with the stack pointer register.
> Removing it will help compiler writers to catch error in case such
> a thunk call is emitted incorrectly.
> 
> Fixes: 76b043848fd2 ("x86/retpoline: Add initial retpoline support")
> Suggested-by: Jeff Law <law@...hat.com>
> Signed-off-by: Waiman Long <longman@...hat.com>

Acked-by: David Woodhouse <dwmw@...zon.co.uk>

I spotted that and *almost* removed it a couple of times in other
refactoring, but after abandoning those I forgot to come back and do
just this. Thanks.

Download attachment "smime.p7s" of type "application/x-pkcs7-signature" (5213 bytes)