linux-kernel - Re: [PATCH v2 2/4] drivers: firmware: xilinx: Add ZynqMP firmware driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180123083823.GB21463@kroah.com>
Date:   Tue, 23 Jan 2018 09:38:23 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Jolly Shah <jolly.shah@...inx.com>
Cc:     ard.biesheuvel@...aro.org, mingo@...nel.org,
        matt@...eblueprint.co.uk, sudeep.holla@....com,
        hkallweit1@...il.com, keescook@...omium.org,
        dmitry.torokhov@...il.com, michal.simek@...inx.com,
        robh+dt@...nel.org, mark.rutland@....com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, rajanv@...inx.com,
        Jolly Shah <jollys@...inx.com>
Subject: Re: [PATCH v2 2/4] drivers: firmware: xilinx: Add ZynqMP firmware
 driver

On Wed, Jan 17, 2018 at 12:20:32PM -0800, Jolly Shah wrote:
> This patch is adding communication layer with firmware.
> Firmware driver provides an interface to firmware APIs.
> Interface APIs can be used by any driver to communicate to
> PMUFW(Platform Management Unit). All requests go through ATF.
> 
> Signed-off-by: Jolly Shah <jollys@...inx.com>
> Signed-off-by: Rajan Vaja <rajanv@...inx.com>
> ---
>  arch/arm64/Kconfig.platforms                    |   1 +
>  drivers/firmware/Kconfig                        |   1 +
>  drivers/firmware/Makefile                       |   1 +
>  drivers/firmware/xilinx/Kconfig                 |   4 +
>  drivers/firmware/xilinx/Makefile                |   4 +
>  drivers/firmware/xilinx/zynqmp/Kconfig          |  16 +
>  drivers/firmware/xilinx/zynqmp/Makefile         |   4 +
>  drivers/firmware/xilinx/zynqmp/firmware.c       | 987 ++++++++++++++++++++++++
>  include/linux/firmware/xilinx/zynqmp/firmware.h | 570 ++++++++++++++

Why does this file need to be in include/linux/ at all?  Shouldn't it
just live in the driver-specific subdir?

thanks,

greg k-h