linux-kernel - Re: [PATCH] Input: stmfts: set IRQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180123013703.nj7ohi4rylz4om6o@dtor-ws>
Date:   Mon, 22 Jan 2018 17:37:03 -0800
From:   Dmitry Torokhov <dmitry.torokhov@...il.com>
To:     Andi Shyti <andi.shyti@...sung.com>
Cc:     linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
        Andi Shyti <andi@...zian.org>
Subject: Re: [PATCH] Input: stmfts: set IRQ_NOAUTOEN to the irq flag

On Wed, Sep 27, 2017 at 09:58:31PM +0900, Andi Shyti wrote:
> The interrupt is requested before the device is powered on and
> it's value in some cases cannot be reliable. It happens on some
> devices that an interrupt is generated as soon as requested
> before having the chance to disable the irq.
> 
> Set the irq flag as IRQ_NOAUTOEN before requesting it.
> 
> This patch mutes the error:
> 
>   stmfts 2-0049: failed to read events: -11
> 
> received sometimes during boot time.
> 
> Signed-off-by: Andi Shyti <andi.shyti@...sung.com>

Applied, thank you.

> ---
>  drivers/input/touchscreen/stmfts.c | 11 ++++++++---
>  1 file changed, 8 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/input/touchscreen/stmfts.c b/drivers/input/touchscreen/stmfts.c
> index 2351199189a4..362de0001b33 100644
> --- a/drivers/input/touchscreen/stmfts.c
> +++ b/drivers/input/touchscreen/stmfts.c
> @@ -689,6 +689,14 @@ static int stmfts_probe(struct i2c_client *client,
>  
>  	input_set_drvdata(sdata->input, sdata);
>  
> +	/*
> +	 * stmfts_power_on expects interrupt to be disabled, but
> +	 * at this point the device is still off and I do not trust
> +	 * the status of the irq line that can generate some spurious
> +	 * interrupts. To be on the safe side it's better to not enable
> +	 * the interrupts during their request.
> +	 */
> +	irq_set_status_flags(client->irq, IRQ_NOAUTOEN);
>  	err = devm_request_threaded_irq(&client->dev, client->irq,
>  					NULL, stmfts_irq_handler,
>  					IRQF_ONESHOT,
> @@ -696,9 +704,6 @@ static int stmfts_probe(struct i2c_client *client,
>  	if (err)
>  		return err;
>  
> -	/* stmfts_power_on expects interrupt to be disabled */
> -	disable_irq(client->irq);
> -
>  	dev_dbg(&client->dev, "initializing ST-Microelectronics FTS...\n");
>  
>  	err = stmfts_power_on(sdata);
> -- 
> 2.14.2
> 

-- 
Dmitry