linux-kernel - Re: [PATCH v3 2/4] Staging: rtl8723bs: Change names to conform to the kernel code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 23 Jan 2018 11:45:44 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Shreeya Patel <shreeya.patel23498@...il.com>
Cc:     devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/4] Staging: rtl8723bs: Change names to conform to
 the kernel code

On Sat, Jan 20, 2018 at 12:10:55AM +0530, Shreeya Patel wrote:
> Change names of some variables and functions to conform
> to the kernel coding style. The changes include some removal
> of CamelCase warnings and renaming the variable and field names
> that encode their type (eg the pointers seem to start with p).
> 
> Signed-off-by: Shreeya Patel <shreeya.patel23498@...il.com>
> ---
> 
> Changes in v3
>   -Edit the commit message.
> 
>  drivers/staging/rtl8723bs/hal/sdio_ops.c | 714 +++++++++++++++----------------
>  1 file changed, 357 insertions(+), 357 deletions(-)

Please always test-build your patches so you don't get grumpy emails
from kernel maintainers saying your patch breaks the build :(

This give me the following error when applied:

ERROR: "DisableInterrupt8723BSdio" [drivers/staging/rtl8723bs/r8723bs.ko] undefined!
ERROR: "EnableInterrupt8723BSdio" [drivers/staging/rtl8723bs/r8723bs.ko] undefined!
ERROR: "InitInterrupt8723BSdio" [drivers/staging/rtl8723bs/r8723bs.ko] undefined!
ERROR: "InitSysInterrupt8723BSdio" [drivers/staging/rtl8723bs/r8723bs.ko] undefined!

Please fix up and resend.

greg k-h