linux-kernel - Re: [PATCH] mips: dts: Remove leading 0x and 0s from bindings notation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180123114404.GD22211@saruman>
Date:   Tue, 23 Jan 2018 11:44:05 +0000
From:   James Hogan <jhogan@...nel.org>
To:     Mathieu Malaterre <malat@...ian.org>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Paul Burton <paul.burton@...s.com>,
        Mark Rutland <mark.rutland@....com>,
        Ralf Baechle <ralf@...ux-mips.org>,
        Philippe Ombredanne <pombredanne@...b.com>,
        Paul Cercueil <paul@...pouillou.net>,
        Thomas Gleixner <tglx@...utronix.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Harvey Hunt <harvey.hunt@...tec.com>,
        linux-mips@...ux-mips.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mips: dts: Remove leading 0x and 0s from bindings
 notation

On Thu, Dec 14, 2017 at 05:53:56PM +0100, Mathieu Malaterre wrote:
> Improve the DTS files by removing all the leading "0x" and zeros to fix the
> following dtc warnings:
> 
> Warning (unit_address_format): Node /XXX unit name should not have leading "0x"
> 
> and
> 
> Warning (unit_address_format): Node /XXX unit name should not have leading 0s
> 
> Converted using the following command:
> 
> find . -type f \( -iname *.dts -o -iname *.dtsi \) -exec sed -E -i -e "s/@0x([0-9a-fA-F\.]+)\s?\{/@\L\1 \{/g" -e "s/@0+([0-9a-fA-F\.]+)\s?\{/@\L\1 \{/g" {} +
> 
> For simplicity, two sed expressions were used to solve each warnings separately.
> 
> To make the regex expression more robust a few other issues were resolved,
> namely setting unit-address to lower case, and adding a whitespace before the
> the opening curly brace:
> 
> https://elinux.org/Device_Tree_Linux#Linux_conventions
> 
> This is a follow up to commit 4c9847b7375a ("dt-bindings: Remove leading 0x from bindings notation")
> 
> Reported-by: David Daney <ddaney@...iumnetworks.com>
> Suggested-by: Rob Herring <robh@...nel.org>
> Signed-off-by: Mathieu Malaterre <malat@...ian.org>
> ---
>  arch/mips/boot/dts/img/boston.dts   | 2 +-
>  arch/mips/boot/dts/ingenic/ci20.dts | 8 ++++----
>  2 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/mips/boot/dts/img/boston.dts b/arch/mips/boot/dts/img/boston.dts
> index 2cd49b60e030..1bd105428f61 100644
> --- a/arch/mips/boot/dts/img/boston.dts
> +++ b/arch/mips/boot/dts/img/boston.dts
> @@ -157,7 +157,7 @@
>  					#address-cells = <1>;
>  					#size-cells = <0>;
>  
> -					rtc@...8 {
> +					rtc@68 {
>  						compatible = "st,m41t81s";
>  						reg = <0x68>;
>  					};
> diff --git a/arch/mips/boot/dts/ingenic/ci20.dts b/arch/mips/boot/dts/ingenic/ci20.dts
> index a4cc52214dbd..7d5e49e40b0d 100644
> --- a/arch/mips/boot/dts/ingenic/ci20.dts
> +++ b/arch/mips/boot/dts/ingenic/ci20.dts
> @@ -110,22 +110,22 @@
>  					reg = <0x0 0x0 0x0 0x800000>;
>  				};
>  
> -				partition@...00000 {
> +				partition@...000 {
>  					label = "u-boot";
>  					reg = <0x0 0x800000 0x0 0x200000>;
>  				};
>  
> -				partition@...00000 {
> +				partition@...000 {
>  					label = "u-boot-env";
>  					reg = <0x0 0xa00000 0x0 0x200000>;
>  				};
>  
> -				partition@...00000 {
> +				partition@...000 {
>  					label = "boot";
>  					reg = <0x0 0xc00000 0x0 0x4000000>;
>  				};
>  
> -				partition@...c00000 {
> +				partition@...0000 {
>  					label = "system";
>  					reg = <0x0 0x4c00000 0x1 0xfb400000>;

should that one actually be called partition@...0000?

Cheers
James

>  				};
> -- 
> 2.11.0
> 
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)