linux-kernel - Re: [patch v9 4/4] platform/mellanox: mlxreg-hotplug: Modify to use a regmap interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180123035124.GB24956@fury>
Date:   Mon, 22 Jan 2018 19:51:24 -0800
From:   Darren Hart <dvhart@...radead.org>
To:     Vadim Pasternak <vadimp@...lanox.com>
Cc:     andy.shevchenko@...il.com, gregkh@...uxfoundation.org,
        linux-kernel@...r.kernel.org, platform-driver-x86@...r.kernel.org,
        jiri@...nulli.us
Subject: Re: [patch v9 4/4] platform/mellanox: mlxreg-hotplug: Modify to use
 a regmap interface

On Mon, Jan 22, 2018 at 07:49:46PM -0800, Darren Hart wrote:
> On Wed, Jan 17, 2018 at 06:21:56PM +0000, Vadim Pasternak wrote:
> > +#define MLXREG_CORE_LABEL_MAX_SIZE	32
> > +
> >  /**
> >   * struct mlxreg_hotplug_device - I2C device data:
> > + *
> >   * @adapter: I2C device adapter;
> >   * @client: I2C device client;
> >   * @brdinfo: device board information;
> >   * @nr: I2C device adapter number, to which device is to be attached;
> > - * @np - pointer to node platform associated with attribute;
> 
> We just added this in 3/4. This should have just been skipped and done as it is
> here directly, and only enabling ARM support at the end.

Apologies, I was still working on this email when I accidentally sent it instead
of postponing it. The above is true, but I'm working on fixing it in my branch.

No need to resend at this point.

-- 
Darren Hart
VMware Open Source Technology Center