linux-kernel - Re: [PATCH v3 3/7] x86/hyper-v: reenlightenment notifications support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87d120bslq.fsf@vitty.brq.redhat.com>
Date:   Tue, 23 Jan 2018 14:41:05 +0100
From:   Vitaly Kuznetsov <vkuznets@...hat.com>
To:     "Michael Kelley \(EOSG\)" <Michael.H.Kelley@...rosoft.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        kbuild test robot <lkp@...el.com>,
        "kbuild-all\@01.org" <kbuild-all@...org>,
        "kvm\@vger.kernel.org" <kvm@...r.kernel.org>,
        "x86\@kernel.org" <x86@...nel.org>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        Radim Krčmář <rkrcmar@...hat.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        "linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>,
        "devel\@linuxdriverproject.org" <devel@...uxdriverproject.org>,
        Ingo Molnar <mingo@...hat.com>,
        Roman Kagan <rkagan@...tuozzo.com>,
        Andy Lutomirski <luto@...nel.org>,
        "H. Peter Anvin" <hpa@...or.com>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Mohammed Gamal <mmorsy@...hat.com>
Subject: Re: [PATCH v3 3/7] x86/hyper-v: reenlightenment notifications support

Vitaly Kuznetsov <vkuznets@...hat.com> writes:

> "Michael Kelley (EOSG)" <Michael.H.Kelley@...rosoft.com> writes:
>
>> On Fri, 19 Jan 2018, Thomas Gleixner wrote:
>>
>>> 
>>> You added '#include <linux/interrupt.h>' to mshyperv.h which is included in
>>> vclock_gettime.c and pulls in other stuff which fails to expand....
>>
>> Is the declaration of hyperv_reenlightenment_intr() even needed in
>> mshyperv.h?  The '#include <linux/interrupt.h>' is there for the __irq_entry
>> annotation on that declaration.   There's a declaration of the parallel (and
>> unannotated) hyperv_vector_handler(), but that looks like a fossil that
>> isn't needed either.
>>
>
> True,
>
> the only need for the declaration in mshyperv.h is to silence "warning:
> no previous prototype for ‘hyperv_reenlightenment_intr’"; I'm not sure
> if this actually needs fixing.

It seems we can get away with dropping '__visible' and '__irq_entry'
qualifiers from 'hyperv_reenlightenment_intr' declaration in mshyperv.h
while keeping them in hv_init.c for the implementation. This way we can
avoid the nasty 'no previous prototype' warning and not have to add
'#include <linux/interrupt.h>' to mshyperv.h breaking vdso.

I'm inclined to go ahead with this in v4 if nobody objects.

-- 
  Vitaly