linux-kernel - Re: [PATCH v2] HID: elecom: rewrite report fixup for EX-G and future mice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.1801231540110.11852@cbobk.fhfr.pm>
Date:   Tue, 23 Jan 2018 15:40:21 +0100 (CET)
From:   Jiri Kosina <jikos@...nel.org>
To:     Tomasz Kramkowski <tk@...-tk.com>
cc:     Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Yuxuan Shui <yshuiv7@...il.com>,
        Diego Elio Pettenò <flameeyes@...meeyes.eu>,
        Alex Manoussakis <amanou@....org>, linux-input@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] HID: elecom: rewrite report fixup for EX-G and future
 mice

On Tue, 19 Dec 2017, Tomasz Kramkowski wrote:

> This patch rewrites the mouse report fixup used for the DEFT and HUGE
> elecom trackballs in order to make it generic enough to fix other
> elecom mice with similar issues. This patch also uses this new report
> fixup function to fix the Elecom EX-G trackball which has 6 physical
> buttons and a similar issue to the other two mice.
> 
> Elecom's track record has so far shown that they like to re-use the
> same report descriptor for multiple different mice regardless of the
> number of buttons the mouse has. This means that the missing buttons
> on multiple mice can be fixed in one function without introducing
> phantom buttons which would in turn cause the number of mouse buttons
> to be misreported to userspace.
> 
> This patch drops the very verbose report descriptor "diff" comment for
> a more abridged yet hopefully just as informative generic version.
> 
> Signed-off-by: Tomasz Kramkowski <tk@...-tk.com>
> ---
> v2 changes:
> * pass rsize directly to mouse_button_fixup
> * add support for wireless EX-G variant
> v1: https://marc.info/?i=20171204205550.2621-1-tk@the-tk.com

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs