linux-kernel - Re: [PATCHv5 1/5] net: dsa: Support internal phy on 'cpu' port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <64d5fcf0-6bee-b28a-c5b4-ad1868d74d9f@gmail.com>
Date:   Tue, 23 Jan 2018 07:29:00 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Sebastian Reichel <sebastian.reichel@...labora.co.uk>,
        Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...oirfairelinux.com>,
        Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <kernel@...gutronix.de>,
        Fabio Estevam <fabio.estevam@....com>
Cc:     Ian Ray <ian.ray@...com>, Nandor Han <nandor.han@...com>,
        Rob Herring <robh+dt@...nel.org>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel@...ts.collabora.co.uk
Subject: Re: [PATCHv5 1/5] net: dsa: Support internal phy on 'cpu' port



On 01/23/2018 07:03 AM, Sebastian Reichel wrote:
> This adds support for enabling the internal PHY for a 'cpu' port.
> It has been tested on GE B850v3,  B650v3 and B450v3, which have a
> built-in MV88E6240 switch hardwired to a PCIe based network card.
> On these machines the internal PHY of the i210 network card and
> the Marvell switch are connected to each other and must be enabled
> for properly using the switch. While the i210 PHY will be enabled
> when the network interface is enabled, the switch's port is not
> exposed as network interface. Additionally the mv88e6xxx driver
> resets the chip during probe, so the PHY is disabled without this
> patch.

This looks good now, thanks for your patience Sebastian!

> 
> Signed-off-by: Sebastian Reichel <sebastian.reichel@...labora.co.uk>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian