linux-kernel - Re: [PATCH] bnx2: remove redundant initializations of pointers txr and rxr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180123.111725.1910125353313770902.davem@davemloft.net>
Date:   Tue, 23 Jan 2018 11:17:25 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     colin.king@...onical.com
Cc:     rasesh.mody@...ium.com, harish.patil@...ium.com,
        Dept-GELinuxNICDev@...ium.com, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bnx2: remove redundant initializations of pointers txr
 and rxr

From: Colin King <colin.king@...onical.com>
Date: Tue, 23 Jan 2018 09:44:08 +0000

> From: Colin Ian King <colin.king@...onical.com>
> 
> Pointers txr and rxr are being initialized and a few statements later
> are being assigned new values without the original values ever being
> read. The initialized values are therefore redundant and can be
> removed.
> 
> Cleans up clang warnings:
> drivers/net/ethernet/broadcom/bnx2.c:5821:28: warning: Value stored to
> 'txr' during its initialization is never read
> drivers/net/ethernet/broadcom/bnx2.c:5822:28: warning: Value stored to
> 'rxr' during its initialization is never read
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Applied, thanks Colin.