linux-kernel - Re: [PATCH 2/2] net/ibm/emac: wrong bit is used for STA control register write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20180123164444.47989-1-ivan@de.ibm.com>
Date:   Tue, 23 Jan 2018 19:44:44 +0300
From:   Ivan Mikhaylov <ivan@...ibm.com>
To:     Christian Lamparter <chunkeey@...il.com>
Cc:     "David S . Miller" <davem@...emloft.net>,
        Rob Herring <robh@...nel.org>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] net/ibm/emac: wrong bit is used for STA control register write

> So if someone tries to #define EMAC_STACR_STAC_WRITE BIT(18) it would be
> 0x40000 instead. This is where the confusion is coming from. Can you please
> at least mention this somewhere that all the bits in the commit message are
> in "MSB 0" format? It's confusing enough as it is ;).
Yeap, sure, will do.

> Well, the MASK is not used and it now looks odd. So you might as well
> delete it. Maybe as well as all the unused EMACX_STACR_STAC_IND_* macros?
I'll check and delete if it's not used anywhere. Thanks for finding :)